Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2691363002: Centralize FrameSinkId allocation in one place (Closed)
Patch Set: android Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 9f1db2872bbd5f3fa006ee7f5a07050e31c82b76..f069c1756f4fb46db5baadf34d0e6ba6eaac206c 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -446,13 +446,8 @@ RenderWidgetHostViewAndroid::RenderWidgetHostViewAndroid(
// layer is managed by the DelegatedFrameHost.
view_.SetLayer(cc::Layer::Create());
if (using_browser_compositor_) {
- // This FrameSinkId must be unique with ContextProviderFactory's FrameSinkId
- // allocation.
- // TODO(crbug.com/685777): Centralize allocation in one place for easier
- // maintenance.
- cc::FrameSinkId frame_sink_id = cc::FrameSinkId(
- base::checked_cast<uint32_t>(host_->GetProcess()->GetID()),
- base::checked_cast<uint32_t>(host_->GetRoutingID()));
+ cc::FrameSinkId frame_sink_id =
+ host_->AllocateFrameSinkId(false /* is_guest_view_hack */);
delegated_frame_host_.reset(new ui::DelegatedFrameHostAndroid(
&view_, cached_background_color_, this, frame_sink_id));
}

Powered by Google App Engine
This is Rietveld 408576698