Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2691363002: Centralize FrameSinkId allocation in one place (Closed)
Patch Set: android Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 74e7ed4b131dd896ab1751c3234c0bc76dedbf7d..010e0590b5352cbba30cf88ac2cd54b7284a91a5 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -1922,19 +1922,9 @@ void RenderWidgetHostViewAura::CreateDelegatedFrameHostClient() {
if (IsMus())
return;
- // GuestViews have two RenderWidgetHostViews and so we need to make sure
- // we don't have FrameSinkId collisions.
- // The FrameSinkId generated here must be unique with FrameSinkId allocated
- // in ContextFactoryPrivate.
- // TODO(crbug.com/685777): Centralize allocation in one place for easier
- // maintenance.
- ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
cc::FrameSinkId frame_sink_id =
- is_guest_view_hack_
- ? factory->GetContextFactoryPrivate()->AllocateFrameSinkId()
- : cc::FrameSinkId(
- base::checked_cast<uint32_t>(host_->GetProcess()->GetID()),
- base::checked_cast<uint32_t>(host_->GetRoutingID()));
+ host_->AllocateFrameSinkId(is_guest_view_hack_);
+
// Tests may set |delegated_frame_host_client_|.
if (!delegated_frame_host_client_) {
delegated_frame_host_client_ =

Powered by Google App Engine
This is Rietveld 408576698