Split ConditionalFeatures

Split ConditionalFeatures

This CL moves out a lot of core/ specific functionality inside ConditionalFeatures.h/cpp into ConditionalFeaturesForCore.h/cpp. ConditionalFeatures will be moved into platform/. This is necessary for V8PerContextData to move to platform/ (as it calls installConditionalFeatures)

BUG=682322
Review-Url: https://codereview.chromium.org/2691343010
Cr-Commit-Position: refs/heads/master@{#451809}
Committed: https://chromium.googlesource.com/chromium/src/+/de62655cbf94133fe6d83b04aa37afb8519b3290

[adithyas, 2017-02-16 21:27:49]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 21:29:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adithyas, 2017-02-16 21:58:34]

The CQ bit was unchecked by adithyas@chromium.org

[adithyas, 2017-02-16 22:03:03]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 22:05:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adithyas, 2017-02-18 00:04:17]

adithyas@chromium.org changed reviewers:
+ jbroman@chromium.org

[adithyas, 2017-02-18 00:05:27]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 00:06:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:09:08]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Yuki, 2017-02-20 09:34:28]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2017-02-20 09:34:29]

LGTM.

https://codereview.chromium.org/2691343010/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp (right):

https://codereview.chromium.org/2691343010/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp:3: // found
in the LICENSE file
nit: No need to drop the last period.

https://codereview.chromium.org/2691343010/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.h (right):

https://codereview.chromium.org/2691343010/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.h:33: //
Initially set to the private |installPendingConditionalFeatureDefault|
typo: s/Initially/is initially/

https://codereview.chromium.org/2691343010/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.h
(right):

https://codereview.chromium.org/2691343010/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.h:11:
#include "wtf/text/WTFString.h"
nit: No need to include WTFString.h.

[haraken, 2017-02-20 09:36:13]

LGTM

[adithyas, 2017-02-21 15:32:03]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:32:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-02-21 15:52:19]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2017-02-21 15:52:19]

lgtm

[commit-bot: I haz the power, 2017-02-21 18:06:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:06:07]

Dry run: This issue passed the CQ dry run.

[adithyas, 2017-02-21 18:06:53]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-02-21 18:06:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2691343010/#ps80001
(title: "Rebase, code review changes")

[commit-bot: I haz the power, 2017-02-21 18:07:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 19:05:31]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487700413236260,
"parent_rev": "0a9575294c9ad312904e7138e5a0d9d81a7b6c03", "commit_rev":
"de62655cbf94133fe6d83b04aa37afb8519b3290"}

[commit-bot: I haz the power, 2017-02-21 19:06:06]

Description was changed from

==========
Split ConditionalFeatures

This CL moves out a lot of core/ specific functionality inside
ConditionalFeatures.h/cpp into ConditionalFeaturesForCore.h/cpp.
ConditionalFeatures will be moved into platform/. This is necessary for
V8PerContextData to move to platform/ (as it calls installConditionalFeatures)

BUG=682322
==========

to

==========
Split ConditionalFeatures

This CL moves out a lot of core/ specific functionality inside
ConditionalFeatures.h/cpp into ConditionalFeaturesForCore.h/cpp.
ConditionalFeatures will be moved into platform/. This is necessary for
V8PerContextData to move to platform/ (as it calls installConditionalFeatures)

BUG=682322

Review-Url: https://codereview.chromium.org/2691343010
Cr-Commit-Position: refs/heads/master@{#451809}
Committed:
https://chromium.googlesource.com/chromium/src/+/de62655cbf94133fe6d83b04aa37...
==========

[commit-bot: I haz the power, 2017-02-21 19:06:07]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/de62655cbf94133fe6d83b04aa37...