Issue 2691343009: [WebPayments] Enabling unit + browser tests on Mac

Issue 2691343009: [WebPayments] Enabling unit + browser tests on Mac (Closed)

Created:
3 years, 10 months ago by tmartino

Modified:
3 years, 10 months ago

Reviewers:
Mathieu

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[WebPayments] Enabling unit + browser tests on Mac BUG=679127 Review-Url: https://codereview.chromium.org/2691343009 Cr-Commit-Position: refs/heads/master@{#452931} Committed: https://chromium.googlesource.com/chromium/src/+/2869150d31cb0529f16f7d571ef650d1d2bebd99

Patch Set 4 : Take 3 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -22 lines)			Patch
	M	chrome/browser/ui/BUILD.gn	View	1 2 3	1 chunk	+14 lines, -10 lines	0 comments	Download
	M	chrome/test/BUILD.gn	View	1 2 3	5 chunks	+6 lines, -12 lines	0 comments	Download

Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/213393) linux_android_rel_ng on ...

3 years, 10 months ago (2017-02-16 19:39:08 UTC) #4

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

tmartino

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

3 years, 10 months ago (2017-02-16 19:46:39 UTC) #5

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691343009/20001

3 years, 10 months ago (2017-02-16 19:47:45 UTC) #6

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

tmartino

Description was changed from ========== [WebPayments] Enabling tests on Mac BUG= ========== to ========== [WebPayments] ...

3 years, 10 months ago (2017-02-16 19:48:47 UTC) #7

Description was changed from

==========
[WebPayments] Enabling tests on Mac

BUG=
==========

to

==========
[WebPayments] Enabling tests on Mac

BUG=679127
==========

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-02-16 20:20:14 UTC) #8

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/390044)

3 years, 10 months ago (2017-02-16 20:20:15 UTC) #9

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

tmartino

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

3 years, 10 months ago (2017-02-17 19:01:43 UTC) #10

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691343009/40001

3 years, 10 months ago (2017-02-17 19:02:41 UTC) #11

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-02-17 20:06:17 UTC) #12

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/368929)

3 years, 10 months ago (2017-02-17 20:06:18 UTC) #13

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

tmartino

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

3 years, 10 months ago (2017-02-24 18:30:24 UTC) #14

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691343009/60001

3 years, 10 months ago (2017-02-24 18:30:47 UTC) #15

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

tmartino

Description was changed from ========== [WebPayments] Enabling tests on Mac BUG=679127 ========== to ========== [WebPayments] ...

3 years, 10 months ago (2017-02-24 19:07:44 UTC) #16

Description was changed from

==========
[WebPayments] Enabling tests on Mac

BUG=679127
==========

to

==========
[WebPayments] Enabling unit + browser tests on Mac

BUG=679127
==========

tmartino

tmartino@chromium.org changed reviewers: + mathp@chromium.org

3 years, 10 months ago (2017-02-24 19:25:56 UTC) #17

tmartino@chromium.org changed reviewers:
+ mathp@chromium.org

tmartino

3 years, 10 months ago (2017-02-24 19:25:57 UTC) #18

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 10 months ago (2017-02-24 19:43:37 UTC) #19

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

3 years, 10 months ago (2017-02-24 19:43:37 UTC) #20

Dry run: This issue passed the CQ dry run.

Mathieu

Can you update the description to not mention browser tests? lgtm

3 years, 10 months ago (2017-02-24 21:21:37 UTC) #21

Can you update the description to not mention browser tests?

lgtm

tmartino

On 2017/02/24 at 21:21:37, mathp wrote: > Can you update the description to not mention ...

3 years, 10 months ago (2017-02-24 21:24:34 UTC) #22

On 2017/02/24 at 21:21:37, mathp wrote:
> Can you update the description to not mention browser tests?
> 
> lgtm

Resolved offline

tmartino

The CQ bit was checked by tmartino@chromium.org

3 years, 10 months ago (2017-02-24 21:24:38 UTC) #23

The CQ bit was checked by tmartino@chromium.org

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691343009/60001

3 years, 10 months ago (2017-02-24 21:25:35 UTC) #24

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487971478539410, "parent_rev": "2aa2f966bb57aff29459fd4089cb72f96f28e161", "commit_rev": "2869150d31cb0529f16f7d571ef650d1d2bebd99"}

3 years, 10 months ago (2017-02-24 21:34:43 UTC) #25

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487971478539410,
"parent_rev": "2aa2f966bb57aff29459fd4089cb72f96f28e161", "commit_rev":
"2869150d31cb0529f16f7d571ef650d1d2bebd99"}

commit-bot: I haz the power

Description was changed from ========== [WebPayments] Enabling unit + browser tests on Mac BUG=679127 ========== ...

3 years, 10 months ago (2017-02-24 21:35:21 UTC) #26

Message was sent while issue was closed.

Description was changed from

==========
[WebPayments] Enabling unit + browser tests on Mac

BUG=679127
==========

to

==========
[WebPayments] Enabling unit + browser tests on Mac

BUG=679127

Review-Url: https://codereview.chromium.org/2691343009
Cr-Commit-Position: refs/heads/master@{#452931}
Committed:
https://chromium.googlesource.com/chromium/src/+/2869150d31cb0529f16f7d571ef6...
==========

commit-bot: I haz the power

Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/2869150d31cb0529f16f7d571ef650d1d2bebd99

3 years, 10 months ago (2017-02-24 21:35:22 UTC) #27

Message was sent while issue was closed.

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2869150d31cb0529f16f7d571ef6...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages