Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2691343007: Fix assert statement in Git.unstaged_changes. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
wkorman, jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix assert statement in Git.unstaged_changes. In Git.unstaged_changes, there was an assert statement which asserted that git status -z lines should be longer than 4 characters. This is not quite correct, since they can be equal to 4 characters, if the filename is one character. BUG=692032 Review-Url: https://codereview.chromium.org/2691343007 Cr-Commit-Position: refs/heads/master@{#451051} Committed: https://chromium.googlesource.com/chromium/src/+/0ac08e177bbcec4e6d2213da7a46a541633841b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
qyearsley
3 years, 10 months ago (2017-02-15 22:57:45 UTC) #2
wkorman
lgtm
3 years, 10 months ago (2017-02-16 01:43:57 UTC) #4
drott
Thanks!
3 years, 10 months ago (2017-02-16 10:51:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691343007/1
3 years, 10 months ago (2017-02-16 16:53:27 UTC) #7
qyearsley
On 2017/02/16 at 01:43:57, wkorman wrote: > lgtm Thanks for quick review :-)
3 years, 10 months ago (2017-02-16 18:38:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691343007/1
3 years, 10 months ago (2017-02-16 19:03:14 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 19:31:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ac08e177bbcec4e6d2213da7a46...

Powered by Google App Engine
This is Rietveld 408576698