Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2691343002: Markdown instruction how to generate code coverage for LayoutNG (Closed)

Created:
3 years, 10 months ago by Gleb Lanbin
Modified:
3 years, 10 months ago
Reviewers:
atotic, ikilpatrick
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Markdown instruction how to generate code coverage for LayoutNG BUG=635619 Review-Url: https://codereview.chromium.org/2691343002 Cr-Commit-Position: refs/heads/master@{#450447} Committed: https://chromium.googlesource.com/chromium/src/+/2844c8518b8b8aaaa02a44b0ce5e3c3821cb72ed

Patch Set 1 #

Total comments: 2

Patch Set 2 : add #### in the end of each headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/ng/README.md View 1 2 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Gleb Lanbin
3 years, 10 months ago (2017-02-14 18:15:24 UTC) #2
atotic
On 2017/02/14 at 18:15:24, glebl wrote: > lgtm
3 years, 10 months ago (2017-02-14 18:45:50 UTC) #5
atotic
lgtm
3 years, 10 months ago (2017-02-14 18:47:40 UTC) #6
ikilpatrick
lgtm https://codereview.chromium.org/2691343002/diff/1/third_party/WebKit/Source/core/layout/ng/README.md File third_party/WebKit/Source/core/layout/ng/README.md (right): https://codereview.chromium.org/2691343002/diff/1/third_party/WebKit/Source/core/layout/ng/README.md#newcode96 third_party/WebKit/Source/core/layout/ng/README.md:96: #### Environment setup .nit end headers with #### ...
3 years, 10 months ago (2017-02-14 18:50:58 UTC) #7
Gleb Lanbin
https://codereview.chromium.org/2691343002/diff/1/third_party/WebKit/Source/core/layout/ng/README.md File third_party/WebKit/Source/core/layout/ng/README.md (right): https://codereview.chromium.org/2691343002/diff/1/third_party/WebKit/Source/core/layout/ng/README.md#newcode96 third_party/WebKit/Source/core/layout/ng/README.md:96: #### Environment setup On 2017/02/14 18:50:58, ikilpatrick wrote: > ...
3 years, 10 months ago (2017-02-14 19:01:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691343002/20001
3 years, 10 months ago (2017-02-14 19:02:59 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 20:29:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2844c8518b8b8aaaa02a44b0ce5e...

Powered by Google App Engine
This is Rietveld 408576698