Source/modules/webaudio/OscillatorNode.idl - Issue 26913005: start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/OscillatorNode.idl

Issue 26913005: start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webaudio/OscillatorNode.idl

diff --git a/Source/modules/webaudio/OscillatorNode.idl b/Source/modules/webaudio/OscillatorNode.idl

index 949eac60c32695668c17a31b39d59360174a820f..e203419425b843b5f667c0c124a65319edc22b36 100644

--- a/Source/modules/webaudio/OscillatorNode.idl

+++ b/Source/modules/webaudio/OscillatorNode.idl

@@ -47,8 +47,8 @@

readonly attribute AudioParam frequency; // in Hertz

readonly attribute AudioParam detune; // in Cents

- void start(double when);

- void stop(double when);

+ void start(optional double when);

+ void stop(optional double when);

Ken Russell (switch to Gerrit) 2013/10/11 20:19:06 It looks to me like the "optional" argument needs

Raymond Toy (Google) 2013/10/11 20:51:29 Yes. I've raised this issue. See https://github.c

void noteOn(double when);

void noteOff(double when);

« Source/modules/webaudio/AudioBufferSourceNode.idl ('K') | « Source/modules/webaudio/AudioScheduledSourceNode.h ('k') | no next file » | no next file with comments »