Source/modules/webaudio/AudioBufferSourceNode.idl - Issue 26913005: start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioBufferSourceNode.idl

Issue 26913005: start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/webaudio/dom-exceptions-expected.txt ('k') | Source/modules/webaudio/AudioScheduledSourceNode.h » ('j') | Source/modules/webaudio/OscillatorNode.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/AudioBufferSourceNode.idl

diff --git a/Source/modules/webaudio/AudioBufferSourceNode.idl b/Source/modules/webaudio/AudioBufferSourceNode.idl

index 24c95eb3b2fbd93ce11b8be8c1c9bd05efa5d766..14cf8752558b82ee599ea5828b796baceea151bc 100644

--- a/Source/modules/webaudio/AudioBufferSourceNode.idl

+++ b/Source/modules/webaudio/AudioBufferSourceNode.idl

@@ -43,10 +43,10 @@

attribute double loopStart;

attribute double loopEnd;

- [MeasureAs=WebAudioStart] void start(double when);

+ [MeasureAs=WebAudioStart] void start(optional double when);

Ken Russell (switch to Gerrit) 2013/10/11 20:19:06 It's a little weird to use "optional" just for thi

Raymond Toy (Google) 2013/10/11 20:51:29 Let me try this out.

[MeasureAs=WebAudioStart, ImplementedAs=startGrain] void start(double when, double grainOffset);

[MeasureAs=WebAudioStart, ImplementedAs=startGrain] void start(double when, double grainOffset, double grainDuration);

- void stop(double when);

+ void stop(optional double when);

[DeprecateAs=WebAudioLooping, ImplementedAs=loop] attribute boolean looping; // This is an alias for the .loop attribute for backwards compatibility.