Add ANALYSIS_ASSUME_TRUE annotations to DCHECK_OP impl bodies.

Add ANALYSIS_ASSUME_TRUE annotations to DCHECK_OP impl bodies.

The annotations stop static analysis if a comparison-based DCHECK fails,
which is a signal to the static analyzer that the asserted condition
will always be true.

R=danakj@chromium.org,wez@chromium.org
BUG=327707
Review-Url: https://codereview.chromium.org/2691243004
Cr-Commit-Position: refs/heads/master@{#450532}
Committed: https://chromium.googlesource.com/chromium/src/+/9db26fbab2a06135a5519f21324d1a01851cef3d

[danakj, 2017-02-14 21:11:28]

LGTM

[Kevin M, 2017-02-14 21:54:54]

The CQ bit was checked by kmarshall@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:55:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 01:05:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487109294989440, "parent_rev":
"a23d6ceb29374e303c7bfd356c4455fde45ca208", "commit_rev":
"9db26fbab2a06135a5519f21324d1a01851cef3d"}

[commit-bot: I haz the power, 2017-02-15 01:07:28]

Description was changed from

==========
Add ANALYSIS_ASSUME_TRUE annotations to DCHECK_OP impl bodies.

The annotations stop static analysis if a comparison-based DCHECK fails,
which is a signal to the static analyzer that the asserted condition
will always be true.

R=danakj@chromium.org,wez@chromium.org
BUG=327707
==========

to

==========
Add ANALYSIS_ASSUME_TRUE annotations to DCHECK_OP impl bodies.

The annotations stop static analysis if a comparison-based DCHECK fails,
which is a signal to the static analyzer that the asserted condition
will always be true.

R=danakj@chromium.org,wez@chromium.org
BUG=327707

Review-Url: https://codereview.chromium.org/2691243004
Cr-Commit-Position: refs/heads/master@{#450532}
Committed:
https://chromium.googlesource.com/chromium/src/+/9db26fbab2a06135a5519f21324d...
==========

[commit-bot: I haz the power, 2017-02-15 01:07:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9db26fbab2a06135a5519f21324d...