Reland of move header dependencies from sequence_checker.h to sequenced_worker_pool.h

Reland of move header dependencies from sequence_checker.h to sequenced_worker_pool.h (patchset #1 id:1 of https://codereview.chromium.org/2691263002/ )

Reason for revert:
Rebase and reland this CL after the conflicting CL relands.

Original issue's description:
> Revert of Remove header dependencies from sequence_checker.h to sequenced_worker_pool.h (patchset #5 id:450001 of https://codereview.chromium.org/2690533002/ )
> 
> Reason for revert:
> This caused a compile error on a mac bot:
> https://build.chromium.org/p/chromium.mac/buildstatus?builder=ios-device&number=41231
> 
> Original issue's description:
> > Remove header dependencies from sequence_checker.h to sequenced_worker_pool.h
> > 
> > This CL removes #include to sequenced_worker_pool.h in sequence_checker.h
> > by hiding its members into a nested class, and adds #include and forward
> > decls to other files as needed.
> > 
> > Note that the non trivial diffs are in sequence_checker_impl.{h,cc} only.
> > 
> > The header dependency from sequence_checker.h to sequenced_worker_pool.h
> > prevents other headers to use sequence_checker.h due to a dependency
> > cycle.
> > 
> > TBR=sky@chromium.org, kinuko@chromium.org, rdsmith@chromium.org, qinmin@chromium.org, marq@chromium.org, rockot@chromium.org, blundell@chromium.org, oshima@chromium.org, slan@chromium.org, boliu@chromium.org
> > 
> > Review-Url: https://codereview.chromium.org/2690533002
> > Cr-Commit-Position: refs/heads/master@{#450321}
> > Committed: https://chromium.googlesource.com/chromium/src/+/d502a3f2fa0b673a5082c1d601298bd114a9d237
> 
> TBR=gab@chromium.org,sky@chromium.org,kinuko@chromium.org,rdsmith@chromium.org,qinmin@chromium.org,marq@chromium.org,rockot@chromium.org,blundell@chromium.org,oshima@chromium.org,slan@chromium.org,boliu@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> 
> Review-Url: https://codereview.chromium.org/2691263002
> Cr-Commit-Position: refs/heads/master@{#450322}
> Committed: https://chromium.googlesource.com/chromium/src/+/cf6bde97a32beb4b01549bc1105d82c4cd7c589b

TBR=gab@chromium.org,sky@chromium.org,kinuko@chromium.org,rdsmith@chromium.org,qinmin@chromium.org,marq@chromium.org,rockot@chromium.org,blundell@chromium.org,oshima@chromium.org,slan@chromium.org,boliu@chromium.org,msramek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

[tzik, 2017-02-14 12:44:10]

Created Reland of move header dependencies from sequence_checker.h to
sequenced_worker_pool.h

[tzik, 2017-02-14 12:49:14]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 12:49:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 12:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 12:49:42]

Dry run: This issue passed the CQ dry run.

[gab, 2017-02-14 13:00:59]

On 2017/02/14 12:44:10, tzik wrote:
> Created Reland of move header dependencies from sequence_checker.h to
> sequenced_worker_pool.h

Please re-open https://codereview.chromium.org/2690533002 (untick "Closed" in
"Edit issue"), upload a new patch set to it, and re-land from there. I prefer
that to a new CL as it makes it easier to see diffs.

(and close this one)

Thanks

[tzik, 2017-02-14 13:33:19]

On 2017/02/14 13:00:59, gab wrote:
> On 2017/02/14 12:44:10, tzik wrote:
> > Created Reland of move header dependencies from sequence_checker.h to
> > sequenced_worker_pool.h
> 
> Please re-open https://codereview.chromium.org/2690533002 (untick "Closed" in
> "Edit issue"), upload a new patch set to it, and re-land from there. I prefer
> that to a new CL as it makes it easier to see diffs.
> 
> (and close this one)
> 
> Thanks

Done!

[sky, 2017-02-14 18:07:03]

On 2017/02/14 13:00:59, gab wrote:
> On 2017/02/14 12:44:10, tzik wrote:
> > Created Reland of move header dependencies from sequence_checker.h to
> > sequenced_worker_pool.h
> 
> Please re-open https://codereview.chromium.org/2690533002 (untick "Closed" in
> "Edit issue"), upload a new patch set to it, and re-land from there. I prefer
> that to a new CL as it makes it easier to see diffs.
> 
> (and close this one)
> 
> Thanks

You can get the same effect by uploading the first patch is what was originally
landed and the second patch the fix. That said, reopening the original patch has
lots of advantages.

[gab, 2017-02-14 18:39:13]

On 2017/02/14 18:07:03, sky wrote:
> On 2017/02/14 13:00:59, gab wrote:
> > On 2017/02/14 12:44:10, tzik wrote:
> > > Created Reland of move header dependencies from sequence_checker.h to
> > > sequenced_worker_pool.h
> > 
> > Please re-open https://codereview.chromium.org/2690533002 (untick "Closed"
in
> > "Edit issue"), upload a new patch set to it, and re-land from there. I
prefer
> > that to a new CL as it makes it easier to see diffs.
> > 
> > (and close this one)
> > 
> > Thanks
> 
> You can get the same effect by uploading the first patch is what was
originally
> landed and the second patch the fix. That said, reopening the original patch
has
> lots of advantages.

Indeed but re-opening original patch also allows to ride existing l.g.t.m.'s
without pinging reviewers again when it's trivial and as such should be our
favored paradigm IMO.

[sky, 2017-02-14 21:27:03]

On Tue, Feb 14, 2017 at 10:39 AM,  <gab@chromium.org> wrote:
> On 2017/02/14 18:07:03, sky wrote:
>> On 2017/02/14 13:00:59, gab wrote:
>> > On 2017/02/14 12:44:10, tzik wrote:
>> > > Created Reland of move header dependencies from sequence_checker.h to
>> > > sequenced_worker_pool.h
>> >
>> > Please re-open https://codereview.chromium.org/2690533002 (untick
>> > "Closed"
> in
>> > "Edit issue"), upload a new patch set to it, and re-land from there. I
> prefer
>> > that to a new CL as it makes it easier to see diffs.
>> >
>> > (and close this one)
>> >
>> > Thanks
>>
>> You can get the same effect by uploading the first patch is what was
> originally
>> landed and the second patch the fix. That said, reopening the original
>> patch
> has
>> lots of advantages.
>
> Indeed but re-opening original patch also allows to ride existing l.g.t.m.'s
> without pinging reviewers again when it's trivial and as such should be our
> favored paradigm IMO.

+1

The original cl may also have comments, which are easier found if you reopen.

>
> https://codereview.chromium.org/2691243003/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.