Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 2691233002: Updates in network traffic annotations proto definition. (Closed)

Created:
3 years, 10 months ago by Ramin Halavati
Modified:
3 years, 10 months ago
Reviewers:
msramek, battre
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates in network traffic annotations proto definition. Minor updates in comments, samples, and DEPS file for network traffic annotation proto. BUG= Review-Url: https://codereview.chromium.org/2691233002 Cr-Commit-Position: refs/heads/master@{#450292} Committed: https://chromium.googlesource.com/chromium/src/+/1175597e824387e993a7dadd093ca58cdaae9246

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments addressed. #

Patch Set 3 : DEPS updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M tools/traffic_annotation/DEPS View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tools/traffic_annotation/sample_traffic_annotation.cc View 1 3 chunks +12 lines, -9 lines 0 comments Download
M tools/traffic_annotation/traffic_annotation.proto View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Ramin Halavati
Minor updates, please review.
3 years, 10 months ago (2017-02-14 07:32:43 UTC) #2
battre
LGTM with a comment. https://codereview.chromium.org/2691233002/diff/1/tools/traffic_annotation/sample_traffic_annotation.cc File tools/traffic_annotation/sample_traffic_annotation.cc (right): https://codereview.chromium.org/2691233002/diff/1/tools/traffic_annotation/sample_traffic_annotation.cc#newcode19 tools/traffic_annotation/sample_traffic_annotation.cc:19: sender: "Spellcheck Lookup" I think ...
3 years, 10 months ago (2017-02-14 08:09:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691233002/20001
3 years, 10 months ago (2017-02-14 08:12:28 UTC) #6
Ramin Halavati
Comment addressed, landing. https://codereview.chromium.org/2691233002/diff/1/tools/traffic_annotation/sample_traffic_annotation.cc File tools/traffic_annotation/sample_traffic_annotation.cc (right): https://codereview.chromium.org/2691233002/diff/1/tools/traffic_annotation/sample_traffic_annotation.cc#newcode19 tools/traffic_annotation/sample_traffic_annotation.cc:19: sender: "Spellcheck Lookup" On 2017/02/14 08:09:17, ...
3 years, 10 months ago (2017-02-14 08:12:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/363720)
3 years, 10 months ago (2017-02-14 08:19:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691233002/40001
3 years, 10 months ago (2017-02-14 08:39:15 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 08:48:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1175597e824387e993a7dadd093c...

Powered by Google App Engine
This is Rietveld 408576698