Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2691223003: Short term improvments to the NTP with Chrome Home enabled. (Closed)

Created:
3 years, 10 months ago by Ted C
Modified:
3 years, 10 months ago
Reviewers:
mdjones
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Short term improvments to the NTP with Chrome Home enabled. Use the normal toolbar for the NTP and disable URL focus animations while Chrome Home is enabled. This makes the existing NTP slightly more usable during the transition. BUG=671361 Review-Url: https://codereview.chromium.org/2691223003 Cr-Commit-Position: refs/heads/master@{#450418} Committed: https://chromium.googlesource.com/chromium/src/+/ba2e436f3a981bed44d11709dc2cf13e088b8021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Ted C
PTAL
3 years, 10 months ago (2017-02-14 17:52:29 UTC) #2
mdjones
lgtm. Not that it affects this change, but one thing to keep in mind is ...
3 years, 10 months ago (2017-02-14 17:59:03 UTC) #3
Ted C
On 2017/02/14 17:59:03, mdjones wrote: > lgtm. Not that it affects this change, but one ...
3 years, 10 months ago (2017-02-14 18:01:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691223003/1
3 years, 10 months ago (2017-02-14 18:02:18 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 18:43:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba2e436f3a981bed44d11709dc2c...

Powered by Google App Engine
This is Rietveld 408576698