Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2691223002: Revert of MD Settings: Fix the Network Prediction toggle box. (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
tommycli, stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MD Settings: Fix the Network Prediction toggle box. (patchset #4 id:60001 of https://codereview.chromium.org/2681373002/ ) Reason for revert: Causing stack overflow errors on chrome://md-settings Original issue's description: > MD Settings: Fix the Network Prediction toggle box. > > In order to fix this toggle, I had to update the > SettingsBooleanControlBehavior to support non 0/1 values for numeric > prefs. > > BUG=664048 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2681373002 > Cr-Commit-Position: refs/heads/master@{#450063} > Committed: https://chromium.googlesource.com/chromium/src/+/898ecc48fb6440230a819bcbd113f90c0d0df11e TBR=stevenjb@chromium.org,tommycli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664048 Review-Url: https://codereview.chromium.org/2691223002 Cr-Commit-Position: refs/heads/master@{#450261} Committed: https://chromium.googlesource.com/chromium/src/+/72af2d7297c841948cff5a1961634422c39ff51e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -94 lines) Patch
M chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js View 3 chunks +3 lines, -18 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.js View 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/test/data/webui/settings/settings_toggle_button_tests.js View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dan Beam
Created Revert of MD Settings: Fix the Network Prediction toggle box.
3 years, 10 months ago (2017-02-14 05:16:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691223002/1
3 years, 10 months ago (2017-02-14 05:17:16 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 05:22:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72af2d7297c841948cff5a196163...

Powered by Google App Engine
This is Rietveld 408576698