Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2691213003: Reland improvements to causal async stack traces (Closed)

Created:
3 years, 10 months ago by Cutch
Modified:
3 years, 10 months ago
Reviewers:
devoncarew, rmacnak, siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland improvements to causal async stack traces Original CL: https://codereview.chromium.org/2690683002 Improvements to causal async stack traces UX improvements: - [x] Stop printing the suffix <%s_async_body> and <%s_async_gen_body> for the generated closures. Fixes #28743 - [x] Don't include the duplicate frame below the asynchronous suspension marker. Fixes #28742 Bug fixes: - [x] Fix service protocol enum naming so that it is consistent with other enums. Fixes #28726 Misc: - [x] Stop using package:stack_trace now that the VM does it for us. BUG= R=asiva@google.com, devoncarew@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/19abef97f108461c7cc77e949b84ab078213c301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -54 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/causal_async_stack_contents_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/causal_async_star_stack_contents_test.dart View 3 chunks +10 lines, -14 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 3 chunks +20 lines, -22 lines 0 comments Download
M runtime/vm/debugger.h View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +25 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/vm/causal_async_exception_stack2_test.dart View 1 chunk +98 lines, -0 lines 0 comments Download
M tests/language/vm/causal_async_exception_stack_test.dart View 2 chunks +39 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Cutch
TBR
3 years, 10 months ago (2017-02-14 12:58:37 UTC) #1
Cutch
3 years, 10 months ago (2017-02-14 13:00:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
19abef97f108461c7cc77e949b84ab078213c301 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698