Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: runtime/observatory/lib/src/service/object.dart

Issue 2691213003: Reland improvements to causal async stack traces (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/causal_async_stack_contents_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of service; 5 part of service;
6 6
7 // Some value smaller than the object ring, so requesting a large array 7 // Some value smaller than the object ring, so requesting a large array
8 // doesn't result in an expired ref because the elements lapped it in the 8 // doesn't result in an expired ref because the elements lapped it in the
9 // object ring. 9 // object ring.
10 const int kDefaultFieldLimit = 100; 10 const int kDefaultFieldLimit = 100;
(...skipping 4415 matching lines...) Expand 10 before | Expand all | Expand 10 after
4426 this.location = map['location']; 4426 this.location = map['location'];
4427 this.code = map['code']; 4427 this.code = map['code'];
4428 this.variables = map['vars'] ?? []; 4428 this.variables = map['vars'] ?? [];
4429 } 4429 }
4430 4430
4431 M.FrameKind _fromString(String frameKind) { 4431 M.FrameKind _fromString(String frameKind) {
4432 if (frameKind == null) { 4432 if (frameKind == null) {
4433 return M.FrameKind.regular; 4433 return M.FrameKind.regular;
4434 } 4434 }
4435 switch (frameKind) { 4435 switch (frameKind) {
4436 case 'kRegular': return M.FrameKind.regular; 4436 case 'Regular': return M.FrameKind.regular;
4437 case 'kAsyncCausal': return M.FrameKind.asyncCausal; 4437 case 'AsyncCausal': return M.FrameKind.asyncCausal;
4438 case 'kAsyncSuspensionMarker': return M.FrameKind.asyncSuspensionMarker; 4438 case 'AsyncSuspensionMarker': return M.FrameKind.asyncSuspensionMarker;
4439 default: 4439 default:
4440 throw new UnsupportedError('Unknown FrameKind: $frameKind'); 4440 throw new UnsupportedError('Unknown FrameKind: $frameKind');
4441 } 4441 }
4442 } 4442 }
4443 4443
4444 String toString() { 4444 String toString() {
4445 if (function != null) { 4445 if (function != null) {
4446 return "Frame([$kind] ${function.qualifiedName} $location)"; 4446 return "Frame([$kind] ${function.qualifiedName} $location)";
4447 } else if (location != null) { 4447 } else if (location != null) {
4448 return "Frame([$kind] $location)"; 4448 return "Frame([$kind] $location)";
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
4554 var v = list[i]; 4554 var v = list[i];
4555 if ((v is Map) && _isServiceMap(v)) { 4555 if ((v is Map) && _isServiceMap(v)) {
4556 list[i] = owner.getFromMap(v); 4556 list[i] = owner.getFromMap(v);
4557 } else if (v is List) { 4557 } else if (v is List) {
4558 _upgradeList(v, owner); 4558 _upgradeList(v, owner);
4559 } else if (v is Map) { 4559 } else if (v is Map) {
4560 _upgradeMap(v, owner); 4560 _upgradeMap(v, owner);
4561 } 4561 }
4562 } 4562 }
4563 } 4563 }
OLDNEW
« no previous file with comments | « no previous file | runtime/observatory/tests/service/causal_async_stack_contents_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698