Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2691213002: Move gtest param interface to the necessary class. (Closed)

Created:
3 years, 10 months ago by hidehiko
Modified:
3 years, 10 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, emaxx
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move gtest param interface to the necessary class. Parameterized test is used only for ArcSessionOobeOptInNegotiatorTest now. So, move the inheritance WithParamInterface from base class to the actually using class. It should be much clear policy, and it also allows other test classes inheriting the base class to use parameterized tests. BUG=None TEST=Ran bots. Review-Url: https://codereview.chromium.org/2691213002 Cr-Commit-Position: refs/heads/master@{#450422} Committed: https://chromium.googlesource.com/chromium/src/+/00e934cfb7e965d9f37193aaa1adc685e1ed7d82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/chromeos/arc/arc_session_manager_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
hidehiko
PTAL.
3 years, 10 months ago (2017-02-14 05:00:56 UTC) #5
Yusuke Sato
lgtm
3 years, 10 months ago (2017-02-14 18:09:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691213002/1
3 years, 10 months ago (2017-02-14 18:42:24 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 18:49:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00e934cfb7e965d9f37193aaa1ad...

Powered by Google App Engine
This is Rietveld 408576698