Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2514)

Unified Diff: experimental/PdfViewer/SkPdfReporter.h

Issue 26912005: mode code cleanup (100c / l, comments) (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « experimental/PdfViewer/SkPdfRenderer.cpp ('k') | experimental/PdfViewer/SkPdfReporter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/PdfViewer/SkPdfReporter.h
===================================================================
--- experimental/PdfViewer/SkPdfReporter.h (revision 11629)
+++ experimental/PdfViewer/SkPdfReporter.h (working copy)
@@ -14,9 +14,11 @@
class SkPdfNativeObject;
class SkPdfContext;
+// TODO(edisonn): ability to turn on asserts for known good files
+
enum SkPdfIssueSeverity {
kInfo_SkPdfIssueSeverity,
- kCodeWarning_SkPdfIssueSeverity, // e.g. like NYI, which has nothing to do with an error in the file
+ kCodeWarning_SkPdfIssueSeverity, // e.g. like NYI, PDF file is Ok.
kWarning_SkPdfIssueSeverity,
kIgnoreError_SkPdfIssueSeverity,
kError_SkPdfIssueSeverity,
@@ -51,15 +53,24 @@
kNoFlateLibrary_SkPdfIssue,
kBadStream_SkPdfIssue,
-
_kCount__SkPdfIssue
};
#ifdef PDF_REPORT
-void SkPdfReportIf(bool report, SkPdfIssueSeverity sev, SkPdfIssue issue, const char* context, const SkPdfNativeObject* obj, SkPdfContext* pdfContext);
-void SkPdfReport( SkPdfIssueSeverity sev, SkPdfIssue issue, const char* context, const SkPdfNativeObject* obj, SkPdfContext* pdfContext);
-void SkPdfReportUnexpectedType( SkPdfIssueSeverity sev, const char* context, const SkPdfNativeObject* obj, int anyOfTypes, SkPdfContext* pdfContext);
+void SkPdfReportIf(bool report,
+ SkPdfIssueSeverity sev, SkPdfIssue issue,
+ const char* context,
+ const SkPdfNativeObject* obj,
+ SkPdfContext* pdfContext);
+void SkPdfReport(SkPdfIssueSeverity sev, SkPdfIssue issue,
+ const char* context,
+ const SkPdfNativeObject* obj,
+ SkPdfContext* pdfContext);
+void SkPdfReportUnexpectedType(SkPdfIssueSeverity sev,
+ const char* context,
+ const SkPdfNativeObject* obj, int anyOfTypes,
+ SkPdfContext* pdfContext);
#define SkPdfREPORTCODE(code) code
#else // !PDF_REPORT
« no previous file with comments | « experimental/PdfViewer/SkPdfRenderer.cpp ('k') | experimental/PdfViewer/SkPdfReporter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698