Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: experimental/PdfViewer/SkPdfReporter.cpp

Issue 26912005: mode code cleanup (100c / l, comments) (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « experimental/PdfViewer/SkPdfReporter.h ('k') | experimental/PdfViewer/SkPdfUtils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/PdfViewer/SkPdfReporter.cpp
===================================================================
--- experimental/PdfViewer/SkPdfReporter.cpp (revision 11629)
+++ experimental/PdfViewer/SkPdfReporter.cpp (working copy)
@@ -30,22 +30,33 @@
// TODO(edisonn): add a flag to set the minimum warning level
#ifdef PDF_REPORT
-void SkPdfReport( SkPdfIssueSeverity sev, SkPdfIssue issue, const char* context, const SkPdfNativeObject* obj, SkPdfContext* pdfContext) {
+void SkPdfReport(SkPdfIssueSeverity sev, SkPdfIssue issue,
+ const char* context,
+ const SkPdfNativeObject* obj,
+ SkPdfContext* pdfContext) {
if (sev >= kIgnoreError_SkPdfIssueSeverity) {
printf("%s: %s\n", getSeverityName(sev), context);
}
}
-void SkPdfReportUnexpectedType(SkPdfIssueSeverity sev, const char* context, const SkPdfNativeObject* obj, int anyOfTypes, SkPdfContext* pdfContext) {
+void SkPdfReportIf(bool report,
+ SkPdfIssueSeverity sev, SkPdfIssue issue,
+ const char* context,
+ const SkPdfNativeObject* obj,
+SkPdfContext* pdfContext) {
+ if (!report) {
+ return;
+ }
+ SkPdfReport(sev, issue, context, obj, pdfContext);
+}
+
+void SkPdfReportUnexpectedType(SkPdfIssueSeverity sev,
+ const char* context,
+ const SkPdfNativeObject* obj,
+ int anyOfTypes, SkPdfContext* pdfContext) {
if (sev >= kIgnoreError_SkPdfIssueSeverity) {
printf("%s: %s\n", getSeverityName(sev), context);
}
}
-void SkPdfReportIf(bool report, SkPdfIssueSeverity sev, SkPdfIssue issue, const char* context, const SkPdfNativeObject* obj, SkPdfContext* pdfContext) {
- if (!report) {
- return;
- }
- SkPdfReport(sev, issue, context, obj, pdfContext);
-}
#endif // PDF_REPORT
« no previous file with comments | « experimental/PdfViewer/SkPdfReporter.h ('k') | experimental/PdfViewer/SkPdfUtils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698