Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: experimental/PdfViewer/SkPdfGraphicsState.h

Issue 26912005: mode code cleanup (100c / l, comments) (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « experimental/PdfViewer/SkPdfFont.cpp ('k') | experimental/PdfViewer/SkPdfGraphicsState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/PdfViewer/SkPdfGraphicsState.h
===================================================================
--- experimental/PdfViewer/SkPdfGraphicsState.h (revision 11625)
+++ experimental/PdfViewer/SkPdfGraphicsState.h (working copy)
@@ -13,8 +13,6 @@
#include "SkPdfConfig.h"
#include "SkPdfUtils.h"
-//#include "SkTDStack.h"
-
class SkPdfFont;
class SkPdfDoc;
class SkPdfNativeObject;
@@ -461,10 +459,8 @@
+ // TODO(edisonn): some defaults are contextual, they could on colorspace, pdf version, ...
-
-
-
SkPdfGraphicsState() {
fCurPosX = 0.0;
fCurPosY = 0.0;
@@ -493,19 +489,18 @@
fSMask = NULL;
}
- // TODO(edisonn): make two functons instead, stroking and non stoking, avoid branching
+ // TODO(edisonn): make two functions instead, stroking and non stoking, avoid branching
void applyGraphicsState(SkPaint* paint, bool stroking);
};
-// TODO(edisonn): better class design.
-// TODO(edisonn): rename to SkPdfContext
class SkPdfContext {
public:
SkTDStackNew<SkPdfNativeObject*> fObjectStack;
SkTDStackNew<SkPdfGraphicsState> fStateStack;
SkPdfGraphicsState fGraphicsState;
SkPdfNativeDoc* fPdfDoc;
- // TODO(edisonn): the allocator, could be freed after the page is done drawing.
+ // TODO(edisonn): the allocator, could be freed after the page is done drawing, so we have the
+ // pixels on the screen asap.
SkPdfAllocator* fTmpPageAllocator;
SkMatrix fOriginalMatrix;
« no previous file with comments | « experimental/PdfViewer/SkPdfFont.cpp ('k') | experimental/PdfViewer/SkPdfGraphicsState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698