Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3631)

Unified Diff: experimental/PdfViewer/SkPdfGraphicsState.cpp

Issue 26912005: mode code cleanup (100c / l, comments) (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « experimental/PdfViewer/SkPdfGraphicsState.h ('k') | experimental/PdfViewer/SkPdfRenderer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: experimental/PdfViewer/SkPdfGraphicsState.cpp
===================================================================
--- experimental/PdfViewer/SkPdfGraphicsState.cpp (revision 11625)
+++ experimental/PdfViewer/SkPdfGraphicsState.cpp (working copy)
@@ -6,9 +6,9 @@
*/
#include "SkPdfGraphicsState.h"
-#include "SkPdfNativeTokenizer.h"
#include "SkDashPathEffect.h"
+#include "SkPdfNativeTokenizer.h"
SkPdfContext::SkPdfContext(SkPdfNativeDoc* doc)
: fPdfDoc(doc)
@@ -26,17 +26,19 @@
fNonStroking.applyGraphicsState(paint);
}
- // TODO(edisonn): get this from pdfContext->options,
+ // TODO(edisonn): Perf, we should load this option from pdfContext->options,
// or pdfContext->addPaintOptions(&paint);
paint->setAntiAlias(true);
// TODO(edisonn): miter, ...
if (stroking) {
paint->setStrokeWidth(SkDoubleToScalar(fLineWidth));
- // TODO(edisonn): perf, two sets of allocs, create SkDashPathEffect constr that takes ownership
+ // TODO(edisonn): perf, avoid allocs allocs
// of the intervals
if (fDashArrayLength > 0) {
- paint->setPathEffect(new SkDashPathEffect(fDashArray, fDashArrayLength, fDashPhase))->unref();
+ paint->setPathEffect(new SkDashPathEffect(fDashArray,
+ fDashArrayLength,
+ fDashPhase))->unref();
}
}
« no previous file with comments | « experimental/PdfViewer/SkPdfGraphicsState.h ('k') | experimental/PdfViewer/SkPdfRenderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698