Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2691183002: Check if the focused view is valid (Closed)

Created:
3 years, 10 months ago by oshima
Modified:
3 years, 10 months ago
Reviewers:
achuithb, sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if the focused view is valid BUG=687232 Review-Url: https://codereview.chromium.org/2691183002 Cr-Commit-Position: refs/heads/master@{#450263} Committed: https://chromium.googlesource.com/chromium/src/+/33c1e1d128713823e6fcc89deaaa92d7f832bdd5

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/views/focus/focus_manager.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
achuithb
lgtm since this CHECK seems to implement Scott's suggestion in https://bugs.chromium.org/p/chromium/issues/detail?id=687232#c5
3 years, 10 months ago (2017-02-14 03:47:40 UTC) #7
sky
LGTM
3 years, 10 months ago (2017-02-14 04:23:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691183002/20001
3 years, 10 months ago (2017-02-14 05:12:06 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 05:24:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/33c1e1d128713823e6fcc89deaaa...

Powered by Google App Engine
This is Rietveld 408576698