Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2691123002: Android: fix resource_sizes.py strings normalization. (Closed)

Created:
3 years, 10 months ago by estevenson
Modified:
3 years, 10 months ago
Reviewers:
agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: fix resource_sizes.py strings normalization. When normalizing for the size of untranslated strings in resources.arsc, the number of locale .pak files was used as the number of supported locales. This is inaccurate in Monochrome as most strings will only be available in the 44 Chrome supported locales. This value is now hard-coded in resource_sizes.py. BUG=690672 Review-Url: https://codereview.chromium.org/2691123002 Cr-Commit-Position: refs/heads/master@{#450368} Committed: https://chromium.googlesource.com/chromium/src/+/679ec32b1ab9d0fe56cfec0642b7cadffc815beb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M build/android/resource_sizes.py View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
estevenson
ptal Andrew!
3 years, 10 months ago (2017-02-13 22:08:39 UTC) #4
agrieve
On 2017/02/13 22:08:39, estevenson wrote: > ptal Andrew! lgtm
3 years, 10 months ago (2017-02-14 02:17:38 UTC) #5
agrieve
On 2017/02/14 02:17:38, agrieve wrote: > On 2017/02/13 22:08:39, estevenson wrote: > > ptal Andrew! ...
3 years, 10 months ago (2017-02-14 02:22:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691123002/1
3 years, 10 months ago (2017-02-14 14:48:08 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 15:53:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/679ec32b1ab9d0fe56cfec0642b7...

Powered by Google App Engine
This is Rietveld 408576698