Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2691103007: DevTools: more console setting checkboxes in toolbar (Closed)

Created:
3 years, 10 months ago by luoe
Modified:
3 years, 10 months ago
Reviewers:
lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: more console setting checkboxes in toolbar This CL adds a two column layout in the console's local gear drown with - Checkboxes for 'Monitor XHR requests', 'Show timestamps', and 'Autocomplete from history' - Tooltip for 'Selected context only' BUG=687318 Review-Url: https://codereview.chromium.org/2691103007 Cr-Commit-Position: refs/heads/master@{#451040} Committed: https://chromium.googlesource.com/chromium/src/+/630890d946fe48d816d3e409e6607dedac1552ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -12 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 6 chunks +27 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/consoleView.css View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
luoe
Please take a look, a screenshot is in the crbug.
3 years, 10 months ago (2017-02-16 00:36:25 UTC) #4
pfeldman
lgtm
3 years, 10 months ago (2017-02-16 01:39:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691103007/1
3 years, 10 months ago (2017-02-16 01:41:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-16 03:44:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691103007/1
3 years, 10 months ago (2017-02-16 17:47:00 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 19:15:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/630890d946fe48d816d3e409e660...

Powered by Google App Engine
This is Rietveld 408576698