Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2691093005:
Re-add a rebaseline annotation to some wpt/selection/ tests. (Closed)
DescriptionRe-add a rebaseline annotation to some wpt/selection/ tests.
The annotation was removed in https://codereview.chromium.org/2692793005
and the tests are now failing again.
NOTRY=True
TBR=tkent@chromium.org
BUG=692047
Review-Url: https://codereview.chromium.org/2691093005
Cr-Commit-Position: refs/heads/master@{#450337}
Committed: https://chromium.googlesource.com/chromium/src/+/0b87ebd99156847e983fde16ecca678b90f4e673
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by msramek@chromium.org
Description was changed from ========== Re-add a rebaseline annotation to some wpt/selection/ tests. The annotation was removed in https://codereview.chromium.org/2692793005 and the tests are now failing again. TBR=kent@chromium.org BUG=692047 ========== to ========== Re-add a rebaseline annotation to some wpt/selection/ tests. The annotation was removed in https://codereview.chromium.org/2692793005 and the tests are now failing again. NOTRY=True TBR=kent@chromium.org BUG=692047 ==========
The CQ bit was unchecked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by msramek@chromium.org
Description was changed from ========== Re-add a rebaseline annotation to some wpt/selection/ tests. The annotation was removed in https://codereview.chromium.org/2692793005 and the tests are now failing again. NOTRY=True TBR=kent@chromium.org BUG=692047 ========== to ========== Re-add a rebaseline annotation to some wpt/selection/ tests. The annotation was removed in https://codereview.chromium.org/2692793005 and the tests are now failing again. NOTRY=True TBR=tkent@chromium.org BUG=692047 ==========
msramek@chromium.org changed reviewers: + tkent@chromium.org - kent@chromium.org
Sorry, a typo in the username. +tkent@, adding you to TBR, since your were on the TBR of the CL I'm sort-of reverting.
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487079015834410, "parent_rev":
"28ea8a96d0788781f3ef06053c921d8e740a30ef", "commit_rev":
"76b651da20d4612248adc01466d7c12309d249dd"}
The CQ bit was unchecked by tkent@chromium.org
Thanks. https://codereview.chromium.org/2698443002/ fixed the issue.
Message was sent while issue was closed.
On 2017/02/14 13:35:29, tkent wrote: > Thanks. https://codereview.chromium.org/2698443002/ fixed the issue. That was super fast! Thanks :)
Message was sent while issue was closed.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487079015834410, "parent_rev":
"42098d2b51a7b48696bc664bfe840186926f1575", "commit_rev":
"0b87ebd99156847e983fde16ecca678b90f4e673"}
Message was sent while issue was closed.
Description was changed from ========== Re-add a rebaseline annotation to some wpt/selection/ tests. The annotation was removed in https://codereview.chromium.org/2692793005 and the tests are now failing again. NOTRY=True TBR=tkent@chromium.org BUG=692047 ========== to ========== Re-add a rebaseline annotation to some wpt/selection/ tests. The annotation was removed in https://codereview.chromium.org/2692793005 and the tests are now failing again. NOTRY=True TBR=tkent@chromium.org BUG=692047 Review-Url: https://codereview.chromium.org/2691093005 Cr-Commit-Position: refs/heads/master@{#450337} Committed: https://chromium.googlesource.com/chromium/src/+/0b87ebd99156847e983fde16ecca... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0b87ebd99156847e983fde16ecca... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
