webkit: Catch OSError for when gperf isn't avaliable.

webkit: Catch OSError for when gperf isn't avaliable.

This was fixed for make_css_property_names.py in
https://crrev.com/2521893002 but I missed make_css_value_keywords.py
which also needed the change.

Previously the error output would look like this;
----
[48/17064] ACTION //third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: gen/blink/core/CSSPropertyNames.cpp gen/blink/core/CSSPropertyNames.h
python ../../third_party/WebKit/Source/build/scripts/make_css_property_names.py ../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir gen/blink/core --gperf gperf
Traceback (most recent call last):
  File "../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line 238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File "/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py", line 108, in main
    writer.write_files(options.output_dir)
  File "/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py", line 60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File "../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line 233, in generate_implementation
    gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, universal_newlines=True)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
[79/17064] CXX obj/third_party/angle/libANGLE/Caps.o
----
ninja: Entering directory `out/Release'
[2/3] ACTION //third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: python ../../third_party/WebKit/Source/build/scripts/make_css_property_names.py ../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir gen/blink/core --gperf gperf
--key-positions=*: gperf: command not found
Traceback (most recent call last):
  File "../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line 238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File "/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line 108, in main
    writer.write_files(options.output_dir)
  File "/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line 60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File "../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line 234, in generate_implementation
    return subprocess.check_output(gperf_args, universal_newlines=True, shell=True)
  File "../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line 242, in generate_implementation
    raise subprocess.CalledProcessError(127, gperf_args, output='Command not found.')
subprocess.CalledProcessError: Command '['gperf', '--key-positions=*', '-P', '-n', '-m', '50', '-D']' returned non-zero exit status 127
----

BUG=666161
Review-Url: https://codereview.chromium.org/2691083003
Cr-Commit-Position: refs/heads/master@{#450111}
Committed: https://chromium.googlesource.com/chromium/src/+/9eb78b78bdc41b99596e1b03c40e8eabfa6fe957

[mithro, 2017-02-13 20:02:14]

tansell@chromium.org changed reviewers:
+ ericwilligers@chromium.org, meade@chromium.org

[mithro, 2017-02-13 20:02:15]

Hi!

I missed third_party/WebKit/Source/build/scripts/make_css_value_keywords.py in
https://crrev.com/2521893002

This CL fixes that and then https://crbug.com/666161 can be closed.

Tim 'mithro' Ansell

[Eric Willigers, 2017-02-13 20:29:43]

lgtm

[mithro, 2017-02-13 20:36:55]

The CQ bit was checked by tansell@chromium.org

[commit-bot: I haz the power, 2017-02-13 20:37:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 22:08:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487018215841140, "parent_rev":
"027a80427f6088e66fe7ec024f1dcae7c21e0205", "commit_rev":
"9eb78b78bdc41b99596e1b03c40e8eabfa6fe957"}

[commit-bot: I haz the power, 2017-02-13 22:09:05]

Description was changed from

==========
webkit: Catch OSError for when gperf isn't avaliable.

This was fixed for make_css_property_names.py in
https://crrev.com/2521893002 but I missed make_css_value_keywords.py
which also needed the change.

Previously the error output would look like this;
----
[48/17064] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: gen/blink/core/CSSPropertyNames.cpp gen/blink/core/CSSPropertyNames.h
python ../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 108, in main
    writer.write_files(options.output_dir)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
233, in generate_implementation
    gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, universal_newlines=True)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
[79/17064] CXX obj/third_party/angle/libANGLE/Caps.o
----
ninja: Entering directory `out/Release'
[2/3] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: python
../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
--key-positions=*: gperf: command not found
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
108, in main
    writer.write_files(options.output_dir)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
234, in generate_implementation
    return subprocess.check_output(gperf_args, universal_newlines=True,
shell=True)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
242, in generate_implementation
    raise subprocess.CalledProcessError(127, gperf_args, output='Command not
found.')
subprocess.CalledProcessError: Command '['gperf', '--key-positions=*', '-P',
'-n', '-m', '50', '-D']' returned non-zero exit status 127
----

BUG=666161
==========

to

==========
webkit: Catch OSError for when gperf isn't avaliable.

This was fixed for make_css_property_names.py in
https://crrev.com/2521893002 but I missed make_css_value_keywords.py
which also needed the change.

Previously the error output would look like this;
----
[48/17064] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: gen/blink/core/CSSPropertyNames.cpp gen/blink/core/CSSPropertyNames.h
python ../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 108, in main
    writer.write_files(options.output_dir)
  File
"/usr/local/google/home/djd/chromium/src/third_party/WebKit/Source/build/scripts/in_generator.py",
line 60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
233, in generate_implementation
    gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, universal_newlines=True)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
[79/17064] CXX obj/third_party/angle/libANGLE/Caps.o
----
ninja: Entering directory `out/Release'
[2/3] ACTION
//third_party/WebKit/Source/core:make_core_generated_css_property_names(//build/toolchain/linux:clang_x64)
FAILED: python
../../third_party/WebKit/Source/build/scripts/make_css_property_names.py
../../third_party/WebKit/Source/core/css/CSSProperties.in --output_dir
gen/blink/core --gperf gperf
--key-positions=*: gperf: command not found
Traceback (most recent call last):
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
238, in <module>
    in_generator.Maker(CSSPropertyNamesWriter).main(sys.argv)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
108, in main
    writer.write_files(options.output_dir)
  File
"/fast/chrome/src/third_party/WebKit/Source/build/scripts/in_generator.py", line
60, in write_files
    self._write_file_if_changed(output_dir, generator(), file_name)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
234, in generate_implementation
    return subprocess.check_output(gperf_args, universal_newlines=True,
shell=True)
  File
"../../third_party/WebKit/Source/build/scripts/make_css_property_names.py", line
242, in generate_implementation
    raise subprocess.CalledProcessError(127, gperf_args, output='Command not
found.')
subprocess.CalledProcessError: Command '['gperf', '--key-positions=*', '-P',
'-n', '-m', '50', '-D']' returned non-zero exit status 127
----

BUG=666161

Review-Url: https://codereview.chromium.org/2691083003
Cr-Commit-Position: refs/heads/master@{#450111}
Committed:
https://chromium.googlesource.com/chromium/src/+/9eb78b78bdc41b99596e1b03c40e...
==========

[commit-bot: I haz the power, 2017-02-13 22:09:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9eb78b78bdc41b99596e1b03c40e...