Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2691073004: Remove SafePointAwareMutexLocker (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, haraken, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SafePointAwareMutexLocker Now that we have the per-thread heaps, we no longer need SafePointAwareMutexLocker (because a GCing thread doesn't need to stop other threads that may be waiting on the locker). We can just use MutexLocker. BUG=671856 Review-Url: https://codereview.chromium.org/2691073004 Cr-Commit-Position: refs/heads/master@{#450314} Committed: https://chromium.googlesource.com/chromium/src/+/80d8d295c8f2445ef62ceff89668b15b15ae644d

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -78 lines) Patch
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 2 chunks +3 lines, -5 lines 2 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.h View 2 chunks +1 line, -56 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-14 08:23:18 UTC) #2
sof
https://codereview.chromium.org/2691073004/diff/1/third_party/WebKit/Source/platform/heap/Heap.cpp File third_party/WebKit/Source/platform/heap/Heap.cpp (right): https://codereview.chromium.org/2691073004/diff/1/third_party/WebKit/Source/platform/heap/Heap.cpp#newcode579 third_party/WebKit/Source/platform/heap/Heap.cpp:579: void ThreadHeap::leaveSafePoint() { we can just remove this altogether.
3 years, 10 months ago (2017-02-14 08:31:38 UTC) #3
haraken
https://codereview.chromium.org/2691073004/diff/1/third_party/WebKit/Source/platform/heap/Heap.cpp File third_party/WebKit/Source/platform/heap/Heap.cpp (right): https://codereview.chromium.org/2691073004/diff/1/third_party/WebKit/Source/platform/heap/Heap.cpp#newcode579 third_party/WebKit/Source/platform/heap/Heap.cpp:579: void ThreadHeap::leaveSafePoint() { On 2017/02/14 08:31:38, sof wrote: > ...
3 years, 10 months ago (2017-02-14 08:50:49 UTC) #4
sof
On 2017/02/14 08:50:49, haraken wrote: > https://codereview.chromium.org/2691073004/diff/1/third_party/WebKit/Source/platform/heap/Heap.cpp > File third_party/WebKit/Source/platform/heap/Heap.cpp (right): > > https://codereview.chromium.org/2691073004/diff/1/third_party/WebKit/Source/platform/heap/Heap.cpp#newcode579 > ...
3 years, 10 months ago (2017-02-14 08:52:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691073004/1
3 years, 10 months ago (2017-02-14 08:53:09 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 10:31:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/80d8d295c8f2445ef62ceff89668...

Powered by Google App Engine
This is Rietveld 408576698