Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2691053002: Network Log import UI should default to .json files (Closed)

Created:
3 years, 10 months ago by elawrence
Modified:
3 years, 10 months ago
Reviewers:
eroman
CC:
chromium-reviews, tfarina, bnc+watch_chromium.org, arv+watch_chromium.org, mmenke, eroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Network Log import UI should default to .json files The Import button on chrome://net-internals/#import should default to showing files of type .json to allow users to more easily find the correct file to load. BUG=691606 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2691053002 Cr-Commit-Position: refs/heads/master@{#450001} Committed: https://chromium.googlesource.com/chromium/src/+/529d4230c3d01a4ed528ef3ecf06db1b242f006a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/net_internals/import_view.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
elawrence
Trivial but maybe worthwhile; WDYT?
3 years, 10 months ago (2017-02-13 16:36:28 UTC) #3
eroman
lgtm
3 years, 10 months ago (2017-02-13 16:37:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691053002/1
3 years, 10 months ago (2017-02-13 16:53:29 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 17:55:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/529d4230c3d01a4ed528ef3ecf06...

Powered by Google App Engine
This is Rietveld 408576698