Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2691043006: MD Settings: fix vulcanize build ONCE AND FOR ALL (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix vulcanize build ONCE AND FOR ALL TBR=dpapad@chromium.org BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2691043006 . Cr-Commit-Position: refs/heads/master@{#450276} Committed: https://chromium.googlesource.com/chromium/src/+/8375e5cadbe5433e0e9e6e07e8fc6b30d427d3d3

Patch Set 1 : check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/settings/people_page/fingerprint_browser_proxy.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/fingerprint_list.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dan Beam
3 years, 10 months ago (2017-02-14 06:06:34 UTC) #2
Dan Beam
Committed patchset #1 (id:20001) manually as 8375e5cadbe5433e0e9e6e07e8fc6b30d427d3d3 (presubmit successful).
3 years, 10 months ago (2017-02-14 06:14:17 UTC) #5
dpapad
3 years, 10 months ago (2017-02-14 17:51:24 UTC) #6
Message was sent while issue was closed. 
On 2017/02/14 at 06:14:17, dbeam wrote:
> Committed patchset #1 (id:20001) manually as
8375e5cadbe5433e0e9e6e07e8fc6b30d427d3d3 (presubmit successful).

LGTM

Powered by Google App Engine
This is Rietveld 408576698