Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2691043002: Discard pinning an app with non-empty launcher id. (Closed)

Created:
3 years, 10 months ago by khmel
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge M57] Discard pinning an app with non-empty launcher id. Currently we don't support persisting Chrome shelf pin for app with custom launcher id. We should discard the code that stores pins for such apps in app list sync service which is not compatible with its design. TEST=tests passed and manually on device various pin scenarios BUG=689772 TBR=stevenjb@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2684853002 Cr-Commit-Position: refs/heads/master@{#449126} (cherry picked from commit 613cdf8eeeaac4830b55c4b55b4377269faa2e35) Review-Url: https://codereview.chromium.org/2691043002 Cr-Commit-Position: refs/branch-heads/2987@{#476} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1f9e48f79d14ac701260a68a60cddbeeb89e6f9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -145 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/app_launcher_id.h View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/app_launcher_id.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.h View 4 chunks +5 lines, -42 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.cc View 20 chunks +97 lines, -102 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691043002/1
3 years, 10 months ago (2017-02-13 16:53:27 UTC) #3
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 10 months ago (2017-02-13 17:03:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691043002/1
3 years, 10 months ago (2017-02-13 17:32:29 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 17:34:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f9e48f79d14ac701260a68a60cd...

Powered by Google App Engine
This is Rietveld 408576698