Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2691013003:
Ensure that HD3000 blacklist on Mac covers "any" multi_gpu_category (Closed)
|
Created:
3 years, 10 months ago by ericrk Modified:
3 years, 10 months ago Reviewers:
Zhenyao Mo CC:
chromium-reviews, piman+watch_chromium.org, ccameron Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnsure that HD3000 blacklist on Mac covers "any" multi_gpu_category
HD3000 was previously blacklisted for all GPU features. However, this
only applies when that card is the primary GPU. We've seen issues with
this in the past - moving this to the "any" category, ensuring that we
keep consistent GPU blacklist status around GPU switches.
BUG=661596
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2691013003
Cr-Commit-Position: refs/heads/master@{#450634}
Committed: https://chromium.googlesource.com/chromium/src/+/d0f1bb54f393f66586c7e85ccddfb314a146be61
Patch Set 1 #Patch Set 2 : rebase + add one more missing case #Messages
Total messages: 18 (11 generated)
Description was changed from ========== Ensure that GPU blacklist on Mac covers "any" multi_gpu_category HD3000 was previously blacklisted for any GPU features. However, this only applies when that card is the primary GPU. When GPUs switch, we could re-enable. We've seen issues with this in the past - moving this to the "any" category, ensuring that we keep consistent GPU blacklist status between GPU switches. BUG=661596 ========== to ========== Ensure that GPU blacklist on Mac covers "any" multi_gpu_category HD3000 was previously blacklisted for any GPU features. However, this only applies when that card is the primary GPU. When GPUs switch, we could re-enable. We've seen issues with this in the past - moving this to the "any" category, ensuring that we keep consistent GPU blacklist status between GPU switches. BUG=661596 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Ensure that GPU blacklist on Mac covers "any" multi_gpu_category HD3000 was previously blacklisted for any GPU features. However, this only applies when that card is the primary GPU. When GPUs switch, we could re-enable. We've seen issues with this in the past - moving this to the "any" category, ensuring that we keep consistent GPU blacklist status between GPU switches. BUG=661596 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Ensure that HD3000 blacklist on Mac covers "any" multi_gpu_category HD3000 was previously blacklisted for all GPU features. However, this only applies when that card is the primary GPU. We've seen issues with this in the past - moving this to the "any" category, ensuring that we keep consistent GPU blacklist status around GPU switches. BUG=661596 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
ericrk@chromium.org changed reviewers: + zmo@chromium.org
On 2017/02/14 01:39:37, ericrk wrote: lgtm
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2691013003/#ps20001 (title: "rebase + add one more missing case")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ericrk@chromium.org
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487142738567300,
"parent_rev": "a1fd66f8f404d08f74517fdb6f74db1ca991d818", "commit_rev":
"d0f1bb54f393f66586c7e85ccddfb314a146be61"}
Message was sent while issue was closed.
Description was changed from ========== Ensure that HD3000 blacklist on Mac covers "any" multi_gpu_category HD3000 was previously blacklisted for all GPU features. However, this only applies when that card is the primary GPU. We've seen issues with this in the past - moving this to the "any" category, ensuring that we keep consistent GPU blacklist status around GPU switches. BUG=661596 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Ensure that HD3000 blacklist on Mac covers "any" multi_gpu_category HD3000 was previously blacklisted for all GPU features. However, this only applies when that card is the primary GPU. We've seen issues with this in the past - moving this to the "any" category, ensuring that we keep consistent GPU blacklist status around GPU switches. BUG=661596 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2691013003 Cr-Commit-Position: refs/heads/master@{#450634} Committed: https://chromium.googlesource.com/chromium/src/+/d0f1bb54f393f66586c7e85ccddf... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d0f1bb54f393f66586c7e85ccddf... |
