Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 2690963002: [DeviceService] Move //device/time_zone_monitor to //services/device (Closed)

Created:
2 years, 9 months ago by leonhsl(Using Gerrit)
Modified:
2 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mac-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, blundell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DeviceService] Move //device/time_zone_monitor to //services/device This CL: - moves //device/time_zone_monitor/ into //services/device/, - lets Device Service register all necessary JNIs on its creation, - consolidates all java files under //services/device/ into a single target: //services/device:java, and keeps this target still as part of //content/public/android:content_java, because Device Service is embeded by content_browser service currently. BUG=689394, 687125 TEST=http://crbug.com/288697#c12: load the page, change the system time zone, and then click "recheck" to ensure that the renderer picks up the new time zone. Don't reload the page, which is likely to give you a new renderer process, use the "recheck" link on the page. TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2690963002 Cr-Commit-Position: refs/heads/master@{#450619} Committed: https://chromium.googlesource.com/chromium/src/+/b944ca69b3c6a3c399e93f875b627e3987813ce9

Patch Set 1 : Mechanical movement #

Patch Set 2 : Enable device service to register JNI #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -827 lines) Patch
M content/app/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/app/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/android/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
D device/time_zone_monitor/BUILD.gn View 1 chunk +0 lines, -69 lines 0 comments Download
D device/time_zone_monitor/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D device/time_zone_monitor/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D device/time_zone_monitor/android/java/src/org/chromium/device/time_zone_monitor/TimeZoneMonitor.java View 1 chunk +0 lines, -68 lines 0 comments Download
D device/time_zone_monitor/android/time_zone_monitor_jni_registrar.h View 1 chunk +0 lines, -20 lines 0 comments Download
D device/time_zone_monitor/android/time_zone_monitor_jni_registrar.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D device/time_zone_monitor/public/interfaces/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D device/time_zone_monitor/public/interfaces/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D device/time_zone_monitor/public/interfaces/time_zone_monitor.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
D device/time_zone_monitor/time_zone_monitor.h View 1 chunk +0 lines, -75 lines 0 comments Download
D device/time_zone_monitor/time_zone_monitor.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D device/time_zone_monitor/time_zone_monitor_android.h View 1 chunk +0 lines, -39 lines 0 comments Download
D device/time_zone_monitor/time_zone_monitor_android.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D device/time_zone_monitor/time_zone_monitor_chromeos.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D device/time_zone_monitor/time_zone_monitor_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D device/time_zone_monitor/time_zone_monitor_linux.cc View 1 chunk +0 lines, -173 lines 0 comments Download
D device/time_zone_monitor/time_zone_monitor_mac.mm View 1 chunk +0 lines, -42 lines 0 comments Download
D device/time_zone_monitor/time_zone_monitor_win.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M services/device/BUILD.gn View 1 3 chunks +20 lines, -7 lines 0 comments Download
A services/device/android/register_jni.h View 1 1 chunk +16 lines, -0 lines 0 comments Download
A services/device/android/register_jni.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M services/device/device_service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/device/device_service.cc View 1 1 chunk +12 lines, -1 line 0 comments Download
M services/device/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + services/device/public/interfaces/time_zone_monitor.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/time_zone_monitor/BUILD.gn View 1 3 chunks +9 lines, -14 lines 0 comments Download
A + services/device/time_zone_monitor/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/time_zone_monitor/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/device/time_zone_monitor/android/java/src/org/chromium/device/time_zone_monitor/TimeZoneMonitor.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A services/device/time_zone_monitor/android/time_zone_monitor_jni_registrar.h View 1 chunk +18 lines, -0 lines 0 comments Download
A + services/device/time_zone_monitor/android/time_zone_monitor_jni_registrar.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/device/time_zone_monitor/time_zone_monitor.h View 3 chunks +7 lines, -9 lines 0 comments Download
A + services/device/time_zone_monitor/time_zone_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/time_zone_monitor/time_zone_monitor_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/device/time_zone_monitor/time_zone_monitor_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/time_zone_monitor/time_zone_monitor_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/time_zone_monitor/time_zone_monitor_linux.cc View 2 chunks +2 lines, -4 lines 0 comments Download
A + services/device/time_zone_monitor/time_zone_monitor_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + services/device/time_zone_monitor/time_zone_monitor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/time_zone_monitor/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/time_zone_monitor/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (20 generated)
leonhsl(Using Gerrit)
Hi, Ken, PTAL, Thanks!
2 years, 9 months ago (2017-02-14 09:44:46 UTC) #16
Ken Rockot(use gerrit already)
Nice, LGTM
2 years, 9 months ago (2017-02-14 16:45:51 UTC) #17
leonhsl(Using Gerrit)
+tsepez@ for OWNER review of time_zone_monitor.mojom movement +kinuko@ for content/ OWNER review +haraken@ for third_party/WebKit/Source/modules/ ...
2 years, 9 months ago (2017-02-14 22:14:46 UTC) #19
kinuko
lgtm
2 years, 9 months ago (2017-02-15 00:47:38 UTC) #20
haraken
WebKit/ LGTM
2 years, 9 months ago (2017-02-15 02:17:12 UTC) #21
leonhsl(Using Gerrit)
Thanks all for kindly review! Let me TBR Tom for OWNER review of time_zone_monitor.mojom's mechanical ...
2 years, 9 months ago (2017-02-15 06:58:23 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690963002/40001
2 years, 9 months ago (2017-02-15 06:59:04 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/b944ca69b3c6a3c399e93f875b627e3987813ce9
2 years, 9 months ago (2017-02-15 07:06:08 UTC) #28
leonhsl(Using Gerrit)
2 years, 9 months ago (2017-02-15 07:16:15 UTC) #29
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698