Add ReadIfReady() for tcp_socket_win

Add ReadIfReady() for tcp_socket_win 

This CL adds ReadIfReady() support for TCP socket on Windows.
The new feature is hidden behind a field trial flag, SocketReadIfReady.
Design doc is linked in the bug below.

BUG=690915
Review-Url: https://codereview.chromium.org/2690943004
Cr-Commit-Position: refs/heads/master@{#455239}
Committed: https://chromium.googlesource.com/chromium/src/+/18aeb05270bcd6fac5a33ebb8f1e3614662ac7ec

[xunjieli, 2017-03-03 20:47:20]

Patchset #1 (id:1) has been deleted

[xunjieli, 2017-03-03 20:47:28]

Patchset #1 (id:20001) has been deleted

[xunjieli, 2017-03-03 20:55:14]

Description was changed from

==========
temp do not review

BUG=
==========

to

==========
Add ReadIfReady() for tcp_socket_win 

BUG=690915
==========

[xunjieli, 2017-03-03 22:21:13]

Patchset #1 (id:40001) has been deleted

[xunjieli, 2017-03-03 22:21:21]

Patchset #1 (id:60001) has been deleted

[xunjieli, 2017-03-03 22:21:27]

Patchset #1 (id:80001) has been deleted

[xunjieli, 2017-03-03 22:22:45]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 22:23:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 23:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 23:36:39]

Dry run: This issue passed the CQ dry run.

[xunjieli, 2017-03-06 14:43:04]

Description was changed from

==========
Add ReadIfReady() for tcp_socket_win 

BUG=690915
==========

to

==========
Add ReadIfReady() for tcp_socket_win 

This CL adds ReadIfReady() support for TCP socket on Windows.
The new feature is hidden behind a field trial flag, SocketReadIfReady.
Design doc is linked in the bug below.

BUG=690915
==========

[xunjieli, 2017-03-06 14:43:04]

xunjieli@chromium.org changed reviewers:
+ bnc@chromium.org, davidben@chromium.org

[xunjieli, 2017-03-06 14:43:31]

This one is a whole lot smaller :)
PTAL. Thanks.

https://codereview.chromium.org/2690943004/diff/100001/net/socket/tcp_socket_...
File net/socket/tcp_socket_win.cc (right):

https://codereview.chromium.org/2690943004/diff/100001/net/socket/tcp_socket_...
net/socket/tcp_socket_win.cc:492: DCHECK(!core_->read_iobuffer_.get());
Note: This is not moved to ReadIfReady() because when RetryRead() is called,
|read_iobuffer_| is not null.

[davidben, 2017-03-06 22:09:08]

lgtm

https://codereview.chromium.org/2690943004/diff/100001/net/socket/tcp_socket_...
File net/socket/tcp_socket_win.cc (right):

https://codereview.chromium.org/2690943004/diff/100001/net/socket/tcp_socket_...
net/socket/tcp_socket_win.cc:1044: return;
I think you can replace these three lines with rv = OK.

[xunjieli, 2017-03-06 22:14:03]

https://codereview.chromium.org/2690943004/diff/100001/net/socket/tcp_socket_...
File net/socket/tcp_socket_win.cc (right):

https://codereview.chromium.org/2690943004/diff/100001/net/socket/tcp_socket_...
net/socket/tcp_socket_win.cc:1044: return;
On 2017/03/06 22:09:08, davidben wrote:
> I think you can replace these three lines with rv = OK.

Done. Neat!

[xunjieli, 2017-03-06 22:14:10]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 22:14:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-03-06 23:43:20]

LGTM.

[commit-bot: I haz the power, 2017-03-07 01:06:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:06:50]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xunjieli, 2017-03-07 20:50:31]

Patchset #3 (id:140001) has been deleted

[xunjieli, 2017-03-07 20:50:41]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2017-03-07 20:50:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org, bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/2690943004/#ps160001
(title: "rebased")

[commit-bot: I haz the power, 2017-03-07 20:51:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:07:00]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1488919841933820,
"parent_rev": "ea9f3ee694c2244bdec23b85bdf9ee4a26e95e11", "commit_rev":
"18aeb05270bcd6fac5a33ebb8f1e3614662ac7ec"}

[commit-bot: I haz the power, 2017-03-07 22:07:38]

Description was changed from

==========
Add ReadIfReady() for tcp_socket_win 

This CL adds ReadIfReady() support for TCP socket on Windows.
The new feature is hidden behind a field trial flag, SocketReadIfReady.
Design doc is linked in the bug below.

BUG=690915
==========

to

==========
Add ReadIfReady() for tcp_socket_win 

This CL adds ReadIfReady() support for TCP socket on Windows.
The new feature is hidden behind a field trial flag, SocketReadIfReady.
Design doc is linked in the bug below.

BUG=690915

Review-Url: https://codereview.chromium.org/2690943004
Cr-Commit-Position: refs/heads/master@{#455239}
Committed:
https://chromium.googlesource.com/chromium/src/+/18aeb05270bcd6fac5a33ebb8f1e...
==========

[commit-bot: I haz the power, 2017-03-07 22:07:39]

Committed patchset #3 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/18aeb05270bcd6fac5a33ebb8f1e...