Thread-local weak processing should just use a global weak callback stacks

Thread-local weak processing should just use a global weak callback stacks

Now I don't think there is any reason we have to run the global weak processing
and the thread-local weak processing separately. We can run them at the same
time in the stop-the-world phase.

BUG=671856
Review-Url: https://codereview.chromium.org/2690913002
Cr-Commit-Position: refs/heads/master@{#449926}
Committed: https://chromium.googlesource.com/chromium/src/+/d674502071b65ada9815fdb81b92beeda4add7dc

[haraken, 2017-02-13 02:22:16]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 02:22:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-13 04:14:45]

Description was changed from

==========
Thread-local weak processing should just use a global weak callback stacks

BUG=671856
==========

to

==========
Thread-local weak processing should just use a global weak callback stacks

Now I don't think there is any reason we have to run the global weak processing
and the thread-local weak processing separately. We can run them at the same
time in the stop-the-world phase.

BUG=671856
==========

[haraken, 2017-02-13 04:14:45]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-02-13 04:14:56]

PTAL

[haraken, 2017-02-13 04:17:40]

https://codereview.chromium.org/2690913002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/Heap.cpp (right):

https://codereview.chromium.org/2690913002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/Heap.cpp:313: void* object,

I'll remove the unused parameter and methods in a follow-up.

[sof, 2017-02-13 06:45:00]

lgtm, nice observation.

https://codereview.chromium.org/2690913002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/Heap.cpp (right):

https://codereview.chromium.org/2690913002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/Heap.cpp:313: void* object,
On 2017/02/13 04:17:40, haraken wrote:
> 
> I'll remove the unused parameter and methods in a follow-up.

ok, needed as this is now identical to the above puseGlobalWeakCallback().

[haraken, 2017-02-13 06:45:42]

The CQ bit was unchecked by haraken@chromium.org

[haraken, 2017-02-13 06:45:46]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-02-13 06:45:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 08:23:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 08:23:13]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-02-13 08:29:31]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-02-13 08:29:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 10:42:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486974571025240, "parent_rev":
"2912ffa778a102b9cade9a99eadbe8757c66bb8a", "commit_rev":
"d674502071b65ada9815fdb81b92beeda4add7dc"}

[commit-bot: I haz the power, 2017-02-13 10:42:43]

Description was changed from

==========
Thread-local weak processing should just use a global weak callback stacks

Now I don't think there is any reason we have to run the global weak processing
and the thread-local weak processing separately. We can run them at the same
time in the stop-the-world phase.

BUG=671856
==========

to

==========
Thread-local weak processing should just use a global weak callback stacks

Now I don't think there is any reason we have to run the global weak processing
and the thread-local weak processing separately. We can run them at the same
time in the stop-the-world phase.

BUG=671856

Review-Url: https://codereview.chromium.org/2690913002
Cr-Commit-Position: refs/heads/master@{#449926}
Committed:
https://chromium.googlesource.com/chromium/src/+/d674502071b65ada9815fdb81b92...
==========

[commit-bot: I haz the power, 2017-02-13 10:42:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d674502071b65ada9815fdb81b92...