Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2690893002: Remove SafePointBarrier::parkOthers (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SafePointBarrier::parkOthers Now that the per-thread heap is shipped, we don't need a mechanism to park and resume other threads. BUG=671856 Review-Url: https://codereview.chromium.org/2690893002 Cr-Commit-Position: refs/heads/master@{#449922} Committed: https://chromium.googlesource.com/chromium/src/+/2fd0fddb7497752f6e6abf8e3c7b996466cd62e9

Patch Set 1 #

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -149 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.h View 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.cpp View 3 chunks +1 line, -92 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-13 01:24:21 UTC) #2
sof
lgtm
3 years, 10 months ago (2017-02-13 06:25:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690893002/20001
3 years, 10 months ago (2017-02-13 06:29:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/309527) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, ...
3 years, 10 months ago (2017-02-13 08:10:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690893002/20001
3 years, 10 months ago (2017-02-13 08:18:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/320178)
3 years, 10 months ago (2017-02-13 08:44:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690893002/20001
3 years, 10 months ago (2017-02-13 08:57:06 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 09:46:09 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2fd0fddb7497752f6e6abf8e3c7b...

Powered by Google App Engine
This is Rietveld 408576698