Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2690863003: ColumnBalancer: need to examine lines that protrude into the flow thread portion. (Closed)

Created:
3 years, 10 months ago by mstensho (USE GERRIT)
Modified:
3 years, 10 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ColumnBalancer: need to examine lines that protrude into the flow thread portion. We cannot skip a line that starts before the flow thread portion of interest, if it ends inside the portion. Some extra care is needed to avoid regressions here: The part of a line that starts before the multicol container itself needs to be ignored, or we risk overstretching the multicol container. BUG=642181 Review-Url: https://codereview.chromium.org/2690863003 Cr-Commit-Position: refs/heads/master@{#450033} Committed: https://chromium.googlesource.com/chromium/src/+/2e6930336491fd5bc277dc9476873a684ebeae44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/balance-line-underflow-1.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/balance-line-underflow-2.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/underflow-after-spanner.html View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 10 months ago (2017-02-13 15:59:18 UTC) #6
eae
LGTM
3 years, 10 months ago (2017-02-13 16:11:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690863003/1
3 years, 10 months ago (2017-02-13 17:00:54 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 18:57:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e6930336491fd5bc277dc947687...

Powered by Google App Engine
This is Rietveld 408576698