base: Add comments warning about using insert() a lot on flat_set.

base: Add comments warning about using insert() a lot on flat_set.

insert() is an O(N) operation, making inserting N things O(N^2).
Whereas building a container of things and inserting them into a
new flat_set together is O(NlogN) instead.

R=dcheng@chromium.org, vmpstr@chromium.org

Review-Url: https://codereview.chromium.org/2690853009
Cr-Commit-Position: refs/heads/master@{#450525}
Committed: https://chromium.googlesource.com/chromium/src/+/038533f0a32b7aa67cde74c577d09faef64a5505

[vmpstr, 2017-02-14 20:32:37]

lgtm

[danakj, 2017-02-14 20:41:21]

Description was changed from

==========
base: Add comments warning about using insert() a lot on flat_set.

R=dcheng@chromium.org, vmpstr@chromium.org
==========

to

==========
base: Add comments warning about using insert() a lot on flat_set.

insert() is an O(N) operation, making inserting N things O(N^2).
Whereas building a container of things and inserting them into a
new flat_set together is O(NlogN) instead.

R=dcheng@chromium.org, vmpstr@chromium.org
==========

[danakj, 2017-02-14 20:41:39]

Description was changed from

==========
base: Add comments warning about using insert() a lot on flat_set.

insert() is an O(N) operation, making inserting N things O(N^2).
Whereas building a container of things and inserting them into a
new flat_set together is O(NlogN) instead.

R=dcheng@chromium.org, vmpstr@chromium.org
==========

to

==========
base: Add comments warning about using insert() a lot on flat_set.

insert() is an O(N) operation, making inserting N things O(N^2).
Whereas building a container of things and inserting them into a
new flat_set together is O(N + NlogN) instead.

R=dcheng@chromium.org, vmpstr@chromium.org
==========

[danakj, 2017-02-14 20:41:49]

Description was changed from

==========
base: Add comments warning about using insert() a lot on flat_set.

insert() is an O(N) operation, making inserting N things O(N^2).
Whereas building a container of things and inserting them into a
new flat_set together is O(N + NlogN) instead.

R=dcheng@chromium.org, vmpstr@chromium.org
==========

to

==========
base: Add comments warning about using insert() a lot on flat_set.

insert() is an O(N) operation, making inserting N things O(N^2).
Whereas building a container of things and inserting them into a
new flat_set together is O(NlogN) instead.

R=dcheng@chromium.org, vmpstr@chromium.org
==========

[dcheng, 2017-02-14 21:11:25]

LGTM

[danakj, 2017-02-14 22:14:23]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-02-14 22:15:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 00:25:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487110463325510,
"parent_rev": "6fb1451de0171f8bdd0915c22016750d79c0b3ac", "commit_rev":
"038533f0a32b7aa67cde74c577d09faef64a5505"}

[commit-bot: I haz the power, 2017-02-15 00:26:28]

Description was changed from

==========
base: Add comments warning about using insert() a lot on flat_set.

insert() is an O(N) operation, making inserting N things O(N^2).
Whereas building a container of things and inserting them into a
new flat_set together is O(NlogN) instead.

R=dcheng@chromium.org, vmpstr@chromium.org
==========

to

==========
base: Add comments warning about using insert() a lot on flat_set.

insert() is an O(N) operation, making inserting N things O(N^2).
Whereas building a container of things and inserting them into a
new flat_set together is O(NlogN) instead.

R=dcheng@chromium.org, vmpstr@chromium.org

Review-Url: https://codereview.chromium.org/2690853009
Cr-Commit-Position: refs/heads/master@{#450525}
Committed:
https://chromium.googlesource.com/chromium/src/+/038533f0a32b7aa67cde74c577d0...
==========

[commit-bot: I haz the power, 2017-02-15 00:26:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/038533f0a32b7aa67cde74c577d0...