cc/trees/damage_tracker.cc - Issue 2690753002: cc: Move render surface ownership from layers to the effect tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/damage_tracker.cc

Issue 2690753002: cc: Move render surface ownership from layers to the effect tree (Closed)

Patch Set: Replace repeated calls to LayerImpl::render_surface Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/damage_tracker.cc

diff --git a/cc/trees/damage_tracker.cc b/cc/trees/damage_tracker.cc

index 5db534a713f50c9cc12c1ff17134f53b518cba7a..0910b43115311abf6868837234ed776c24959568 100644

--- a/cc/trees/damage_tracker.cc

+++ b/cc/trees/damage_tracker.cc

@@ -192,8 +192,9 @@ DamageTracker::DamageAccumulator DamageTracker::TrackDamageFromActiveLayers(

if (layer == layer->layer_tree_impl()->hud_layer())

continue;

- if (layer->render_surface() && layer->render_surface() != target_surface)

- ExtendDamageForRenderSurface(layer->render_surface(), &damage);

+ RenderSurfaceImpl* render_surface = layer->render_surface();

+ if (render_surface && render_surface != target_surface)

+ ExtendDamageForRenderSurface(render_surface, &damage);

else

ExtendDamageForLayer(layer, &damage);

}