Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2690743003: Remove references to or invocations of vulcanize.py. It's deleted. (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to or invocations of vulcanize.py. It's deleted. Vulcanize now happens dynamically with GN/Ninja. \o/ R=dpapad@chromium.org BUG=673825 NOTRY=true Review-Url: https://codereview.chromium.org/2690743003 Cr-Commit-Position: refs/heads/master@{#449875} Committed: https://chromium.googlesource.com/chromium/src/+/d51c79fa3431c8611fd75fbff0a987831ff0b802

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M docs/optimizing_web_uis.md View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/reproduce.sh View 1 chunk +0 lines, -3 lines 2 comments Download

Messages

Total messages: 16 (9 generated)
Dan Beam
3 years, 10 months ago (2017-02-11 01:42:08 UTC) #1
dpapad
LGTM https://codereview.chromium.org/2690743003/diff/1/third_party/polymer/v1_0/reproduce.sh File third_party/polymer/v1_0/reproduce.sh (right): https://codereview.chromium.org/2690743003/diff/1/third_party/polymer/v1_0/reproduce.sh#newcode23 third_party/polymer/v1_0/reproduce.sh:23: check_dep "which crisper" "crisper" "npm install -g crisper" ...
3 years, 10 months ago (2017-02-11 02:47:21 UTC) #4
Dan Beam
https://codereview.chromium.org/2690743003/diff/1/third_party/polymer/v1_0/reproduce.sh File third_party/polymer/v1_0/reproduce.sh (right): https://codereview.chromium.org/2690743003/diff/1/third_party/polymer/v1_0/reproduce.sh#newcode23 third_party/polymer/v1_0/reproduce.sh:23: check_dep "which crisper" "crisper" "npm install -g crisper" On ...
3 years, 10 months ago (2017-02-11 02:48:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690743003/1
3 years, 10 months ago (2017-02-11 02:49:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/307994) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 10 months ago (2017-02-11 03:19:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690743003/1
3 years, 10 months ago (2017-02-11 20:55:03 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 20:59:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d51c79fa3431c8611fd75fbff0a9...

Powered by Google App Engine
This is Rietveld 408576698