Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2690723002: [cleanup] Remove redundant block_scope argument from DeclareClassVariable (Closed)

Created:
3 years, 10 months ago by adamk
Modified:
3 years, 10 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove redundant block_scope argument from DeclareClassVariable R=neis@chromium.org Review-Url: https://codereview.chromium.org/2690723002 Cr-Commit-Position: refs/heads/master@{#43144} Committed: https://chromium.googlesource.com/v8/v8/+/0aa6414a936625ffe64dc022195b634837ccd224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/parsing/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
adamk
3 years, 10 months ago (2017-02-11 00:38:45 UTC) #1
neis
lgtm
3 years, 10 months ago (2017-02-13 09:15:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690723002/1
3 years, 10 months ago (2017-02-13 09:16:00 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 09:39:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0aa6414a936625ffe64dc022195b634837c...

Powered by Google App Engine
This is Rietveld 408576698