Use equalIgnoringASCIICase in HttpEquiv.

Use equalIgnoringASCIICase in HttpEquiv.
    
Using equalIgnoringCase is too loose, it's safer to have restricted ASCII set
here.

BUG=678150
Review-Url: https://codereview.chromium.org/2690703002
Cr-Commit-Position: refs/heads/master@{#457861}
Committed: https://chromium.googlesource.com/chromium/src/+/fb07ed0749ddbb4791c03e9a1b996ec1b0fe191b

[lpy, 2017-02-10 22:39:41]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 22:39:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2017-02-10 23:39:44]

lpy@chromium.org changed reviewers:
+ tyoshino@chromium.org

[lpy, 2017-02-10 23:39:44]

PTAL.

[commit-bot: I haz the power, 2017-02-11 00:33:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 00:33:23]

Dry run: This issue passed the CQ dry run.

[lpy, 2017-02-14 00:37:44]

gentle ping for review :)

[lpy, 2017-02-15 06:44:40]

lpy@chromium.org changed reviewers:
+ japhet@chromium.org, yhirano@chromium.org

[lpy, 2017-02-15 06:44:40]

PTAL.

[yhirano, 2017-02-15 07:05:52]

Could you provide a more informative issue description? Also please add tests
(either unittests or layout tests are fine).

[tyoshino (SeeGerritForStatus), 2017-02-17 11:02:26]

On 2017/02/15 07:05:52, yhirano wrote:
> Could you provide a more informative issue description? Also please add tests
> (either unittests or layout tests are fine).

l-g-t-m once yhirano's point is addressed. Just explaining why using
equalIgnoringCase() is inappropriate and what changing to equalIgnoringASCIICase
improves is fine.

Maybe a good place to put a layout test is LayoutTests/http/tests/misc/, or in
WPT
https://github.com/w3c/web-platform-tests/tree/master/html/semantics/document...

[lpy, 2017-03-17 06:42:27]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 06:42:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2017-03-17 06:43:38]

Description was changed from

==========
Use equalIgnoringASCIICase in HttpEquiv.

BUG=678150
==========

to

==========
Use equalIgnoringASCIICase in HttpEquiv.
    
Using equalIgnoringCase is too loose, it's safer to have restricted ASCII set
here.

BUG=678150
==========

[lpy, 2017-03-17 06:44:29]

Thanks, I added a test. Please take a look.

[commit-bot: I haz the power, 2017-03-17 09:05:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 09:05:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2017-03-17 12:59:05]

lgtm

[lpy, 2017-03-17 18:14:53]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 18:15:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 19:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 19:38:22]

Dry run: This issue passed the CQ dry run.

[lpy, 2017-03-17 19:42:21]

The CQ bit was checked by lpy@chromium.org

[commit-bot: I haz the power, 2017-03-17 19:42:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 19:48:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489779741709210,
"parent_rev": "0973bc7dab66d4ff37ccd86aa2688940d0545137", "commit_rev":
"fb07ed0749ddbb4791c03e9a1b996ec1b0fe191b"}

[commit-bot: I haz the power, 2017-03-17 19:48:52]

Description was changed from

==========
Use equalIgnoringASCIICase in HttpEquiv.
    
Using equalIgnoringCase is too loose, it's safer to have restricted ASCII set
here.

BUG=678150
==========

to

==========
Use equalIgnoringASCIICase in HttpEquiv.
    
Using equalIgnoringCase is too loose, it's safer to have restricted ASCII set
here.

BUG=678150

Review-Url: https://codereview.chromium.org/2690703002
Cr-Commit-Position: refs/heads/master@{#457861}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb07ed0749ddbb4791c03e9a1b99...
==========

[commit-bot: I haz the power, 2017-03-17 19:48:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb07ed0749ddbb4791c03e9a1b99...