Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2690663003: [inspector] exposed ExecutionContextId getter by context (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] exposed ExecutionContextId getter by context BUG=none R=pfeldman@chromium.org Review-Url: https://codereview.chromium.org/2690663003 Cr-Commit-Position: refs/heads/master@{#43122} Committed: https://chromium.googlesource.com/v8/v8/+/7cc1694f512bbae571bc13c921b9d348d4b8fb78

Patch Set 1 #

Patch Set 2 : int should be int #

Patch Set 3 : code style tunning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M include/v8-inspector.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/inspector/v8-inspector-session-impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kozy
Pavel, please take a look.
3 years, 10 months ago (2017-02-11 01:38:53 UTC) #1
pfeldman
lgtm
3 years, 10 months ago (2017-02-11 01:57:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690663003/40001
3 years, 10 months ago (2017-02-11 02:09:08 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_ng/builds/800) v8_linux64_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-11 02:12:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690663003/40001
3 years, 10 months ago (2017-02-11 02:13:47 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 02:42:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/7cc1694f512bbae571bc13c921b9d348d4b...

Powered by Google App Engine
This is Rietveld 408576698