Expose a11y modes of web renderers to chrome://accessibility.

Expose a11y modes of web renderers to chrome://accessibility.

This CL creates target descriptors with the actual a11y mode and
passes those to the chrome://accessibility page instead of just
passing on or off. We then construct a number of anchors in
corresponding to each a11y mode. Each mode and be independently
toggled.

BUG=691083
R=dmazzoni

Review-Url: https://codereview.chromium.org/2690653004
Cr-Commit-Position: refs/heads/master@{#450434}
Committed: https://chromium.googlesource.com/chromium/src/+/768f6ef8934131bbfcf415e9a005b8b1a12294ee

[dougt, 2017-02-11 05:19:45]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 05:20:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 05:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 05:22:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dougt, 2017-02-11 05:58:18]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-11 05:58:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 06:47:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 06:47:06]

Dry run: This issue passed the CQ dry run.

[dougt, 2017-02-11 07:39:17]

dmazzoni, ptal

[dmazzoni, 2017-02-13 19:53:42]

https://codereview.chromium.org/2690653004/diff/20001/content/browser/accessi...
File content/browser/accessibility/accessibility_ui.cc (right):

https://codereview.chromium.org/2690653004/diff/20001/content/browser/accessi...
content/browser/accessibility/accessibility_ui.cc:235: AccessibilityMode
currentMode = web_contents->GetAccessibilityMode();
currentMode -> current_mode (in c++ code)

https://codereview.chromium.org/2690653004/diff/20001/content/browser/accessi...
content/browser/accessibility/accessibility_ui.cc:236: // Flip the bit
represented by |mode|. See accessibility_mode_enums.h for
Should this be "bit" or "bits"?

Technically it flips "bits", but it's currently only used to flip one at a time,
I believe

https://codereview.chromium.org/2690653004/diff/20001/content/browser/resourc...
File content/browser/resources/accessibility/accessibility.js (right):

https://codereview.chromium.org/2690653004/diff/20001/content/browser/resourc...
content/browser/resources/accessibility/accessibility.js:8: // Note: keep these
values in sync with the values in
Things that need to be kept in sync are always a maintenance burden - especially
when they cross language boundaries like this.

How about doing one of the following two things:

1. Add a PRESUBMIT that fails if you try to modify 
    content/common/accessibility_mode_enums.h without
    also modifying this file to match. You can use the
    one in ui/accessibility/ as a good example to copy.

2. Alternatively, have accessibility.js load the list of enums
    from C++ code in JSON, for example it would get
    something like {1: "native", 2: "web", ...} during
    initialization.

[dougt, 2017-02-14 15:21:47]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[dougt, 2017-02-14 15:21:53]

https://codereview.chromium.org/2690653004/diff/20001/content/browser/accessi...
File content/browser/accessibility/accessibility_ui.cc (right):

https://codereview.chromium.org/2690653004/diff/20001/content/browser/accessi...
content/browser/accessibility/accessibility_ui.cc:235: AccessibilityMode
currentMode = web_contents->GetAccessibilityMode();
On 2017/02/13 19:53:42, dmazzoni wrote:
> currentMode -> current_mode (in c++ code)

Done.

https://codereview.chromium.org/2690653004/diff/20001/content/browser/accessi...
content/browser/accessibility/accessibility_ui.cc:236: // Flip the bit
represented by |mode|. See accessibility_mode_enums.h for
On 2017/02/13 19:53:42, dmazzoni wrote:
> Should this be "bit" or "bits"?

Plural is correct.  Our mode flags correspond to a single bit hence that's what
I used.  That said, I added this comment to remind the reader what the operand
^= does.

https://codereview.chromium.org/2690653004/diff/20001/content/browser/resourc...
File content/browser/resources/accessibility/accessibility.js (right):

https://codereview.chromium.org/2690653004/diff/20001/content/browser/resourc...
content/browser/resources/accessibility/accessibility.js:8: // Note: keep these
values in sync with the values in
On 2017/02/13 19:53:42, dmazzoni wrote:
> Things that need to be kept in sync are always a maintenance burden -
especially
> when they cross language boundaries like this.
> 
> How about doing one of the following two things:
> 
> 1. Add a PRESUBMIT that fails if you try to modify 
>     content/common/accessibility_mode_enums.h without
>     also modifying this file to match. You can use the
>     one in ui/accessibility/ as a good example to copy.
> 
> 2. Alternatively, have accessibility.js load the list of enums
>     from C++ code in JSON, for example it would get
>     something like {1: "native", 2: "web", ...} during
>     initialization.

Yes, this makes sense.  I would like to do this work in a separate CL.  Wdyt?

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=692087

Note that we have a similar comment here:
https://cs.chromium.org/chromium/src/content/common/accessibility_mode_enums....
which I can address.

[commit-bot: I haz the power, 2017-02-14 15:22:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 16:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 16:19:49]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-02-14 19:18:55]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-02-14 19:18:55]

lgtm

Sounds good!

[commit-bot: I haz the power, 2017-02-14 19:19:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 19:29:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487099935003620,
"parent_rev": "4e19843aade96a4a3b2254ba00896ddd15e5a153", "commit_rev":
"768f6ef8934131bbfcf415e9a005b8b1a12294ee"}

[commit-bot: I haz the power, 2017-02-14 19:29:45]

Description was changed from

==========
Expose a11y modes of web renderers to chrome://accessibility.

This CL creates target descriptors with the actual a11y mode and
passes those to the chrome://accessibility page instead of just
passing on or off. We then construct a number of anchors in
corresponding to each a11y mode. Each mode and be independently
toggled.

BUG=691083

R=dmazzoni
==========

to

==========
Expose a11y modes of web renderers to chrome://accessibility.

This CL creates target descriptors with the actual a11y mode and
passes those to the chrome://accessibility page instead of just
passing on or off. We then construct a number of anchors in
corresponding to each a11y mode. Each mode and be independently
toggled.

BUG=691083

R=dmazzoni

Review-Url: https://codereview.chromium.org/2690653004
Cr-Commit-Position: refs/heads/master@{#450434}
Committed:
https://chromium.googlesource.com/chromium/src/+/768f6ef8934131bbfcf415e9a005...
==========

[commit-bot: I haz the power, 2017-02-14 19:29:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/768f6ef8934131bbfcf415e9a005...