Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2690623003: Update zlib to 1.2.11 (Closed)

Created:
3 years, 10 months ago by Mark Mentovai
Modified:
3 years, 10 months ago
Reviewers:
agl, Adam Rice, gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, yhirano, tyoshino (SeeGerritForStatus)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update zlib to 1.2.11 Reapply and regenerate all local patches to upstream zlib 1.2.11 Explicitly specify 9 as the minimum windowBits value (representing a 512-byte window) during compression in net/websockets even when 8 (representing 256) is received. This was previously silently done during compression. Because of how zlib's deflate is implemented, when windowBits is 9, it will produce a stream that can be decompressed with a 250-byte or larger window. Changes in 1.2.9 (31 Dec 2016) - Fix contrib/minizip to permit unzipping with desktop API [Zouzou] - Improve contrib/blast to return unused bytes - Assure that gzoffset() is correct when appending - Improve compress() and uncompress() to support large lengths - Fix bug in test/example.c where error code not saved - Remedy Coverity warning [Randers-Pehrson] - Improve speed of gzprintf() in transparent mode - Fix inflateInit2() bug when windowBits is 16 or 32 - Change DEBUG macro to ZLIB_DEBUG - Avoid uninitialized access by gzclose_w() - Allow building zlib outside of the source directory - Fix bug that accepted invalid zlib header when windowBits is zero - Fix gzseek() problem on MinGW due to buggy _lseeki64 there - Loop on write() calls in gzwrite.c in case of non-blocking I/O - Add --warn (-w) option to ./configure for more compiler warnings - Reject a window size of 256 bytes if not using the zlib wrapper - Fix bug when level 0 used with Z_HUFFMAN or Z_RLE - Add --debug (-d) option to ./configure to define ZLIB_DEBUG - Fix bugs in creating a very large gzip header - Add uncompress2() function, which returns the input size used - Assure that deflateParams() will not switch functions mid-block - Dramatically speed up deflation for level 0 (storing) - Add gzfread(), duplicating the interface of fread() - Add gzfwrite(), duplicating the interface of fwrite() - Add deflateGetDictionary() function - Use snprintf() for later versions of Microsoft C - Fix *Init macros to use z_ prefix when requested - Replace as400 with os400 for OS/400 support [Monnerat] - Add crc32_z() and adler32_z() functions with size_t lengths - Update Visual Studio project files [AraHaan] Changes in 1.2.10 (2 Jan 2017) - Avoid warnings on snprintf() return value - Fix bug in deflate_stored() for zero-length input - Fix bug in gzwrite.c that produced corrupt gzip files - Remove files to be installed before copying them in Makefile.in - Add warnings when compiling with assembler code Changes in 1.2.11 (15 Jan 2017) - Fix deflate stored bug when pulling last block from window - Permit immediate deflateParams changes before any deflate input BUG=691074, 691075 Review-Url: https://codereview.chromium.org/2690623003 Cr-Commit-Position: refs/heads/master@{#450585} Committed: https://chromium.googlesource.com/chromium/src/+/6d9a6251dfe87183075dc16cfa134e41dc4cee0d

Patch Set 1 #

Patch Set 2 : Drop the inflater change, improve the deflater comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2182 lines, -1580 lines) Patch
M net/websockets/websocket_deflater.cc View 1 1 chunk +23 lines, -1 line 0 comments Download
M third_party/zlib/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/LICENSE View 1 chunk +15 lines, -23 lines 0 comments Download
M third_party/zlib/README.chromium View 1 chunk +19 lines, -34 lines 0 comments Download
M third_party/zlib/adler32.c View 5 chunks +14 lines, -7 lines 0 comments Download
M third_party/zlib/compress.c View 3 chunks +24 lines, -18 lines 0 comments Download
M third_party/zlib/contrib/minizip/iowin32.c View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/zlib/contrib/minizip/unzip.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/contrib/minizip/zip.c View 10 chunks +11 lines, -11 lines 0 comments Download
M third_party/zlib/crc32.c View 9 chunks +29 lines, -12 lines 0 comments Download
M third_party/zlib/deflate.h View 8 chunks +19 lines, -16 lines 0 comments Download
M third_party/zlib/deflate.c View 41 chunks +501 lines, -306 lines 0 comments Download
M third_party/zlib/google.patch View 11 chunks +236 lines, -255 lines 0 comments Download
M third_party/zlib/gzguts.h View 5 chunks +16 lines, -7 lines 0 comments Download
M third_party/zlib/gzlib.c View 11 chunks +17 lines, -14 lines 0 comments Download
M third_party/zlib/gzread.c View 12 chunks +110 lines, -50 lines 0 comments Download
M third_party/zlib/gzwrite.c View 18 chunks +210 lines, -122 lines 0 comments Download
M third_party/zlib/infback.c View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/zlib/inffast.c View 11 chunks +34 lines, -51 lines 0 comments Download
M third_party/zlib/inflate.h View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/zlib/inflate.c View 29 chunks +86 lines, -37 lines 0 comments Download
M third_party/zlib/inftrees.c View 6 chunks +12 lines, -14 lines 0 comments Download
D third_party/zlib/mozzconf.h View 1 chunk +0 lines, -186 lines 0 comments Download
A third_party/zlib/names.h View 1 chunk +167 lines, -0 lines 0 comments Download
M third_party/zlib/simd.patch View 28 chunks +119 lines, -97 lines 0 comments Download
M third_party/zlib/simd_stub.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/trees.c View 23 chunks +38 lines, -61 lines 0 comments Download
M third_party/zlib/uncompr.c View 2 chunks +66 lines, -32 lines 0 comments Download
M third_party/zlib/x86.c View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/zlib/zconf.h View 10 chunks +33 lines, -10 lines 0 comments Download
M third_party/zlib/zlib.h View 50 chunks +303 lines, -160 lines 0 comments Download
M third_party/zlib/zutil.h View 7 chunks +39 lines, -21 lines 0 comments Download
M third_party/zlib/zutil.c View 10 chunks +25 lines, -24 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Mark Mentovai
agl for third_party/zlib ricea for net/websockets This is a bit of a mess to say ...
3 years, 10 months ago (2017-02-13 03:27:48 UTC) #11
Adam Rice
lgtm for net/websockets
3 years, 10 months ago (2017-02-13 04:52:43 UTC) #12
Mark Mentovai
+gavinp from third_party/zlib/OWNERS
3 years, 10 months ago (2017-02-14 01:52:29 UTC) #14
Mark Mentovai
Ping: Adam or Gavin?
3 years, 10 months ago (2017-02-14 21:48:42 UTC) #15
agl
LGTM. Substantially a rubber-stamp since I mostly glanced at the zlib changes and have to ...
3 years, 10 months ago (2017-02-15 02:37:04 UTC) #16
Mark Mentovai
agl wrote: > LGTM. > > Substantially a rubber-stamp since I mostly glanced at the ...
3 years, 10 months ago (2017-02-15 03:58:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690623003/20001
3 years, 10 months ago (2017-02-15 03:59:50 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 06:16:08 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6d9a6251dfe87183075dc16cfa13...

Powered by Google App Engine
This is Rietveld 408576698