Fixes bug in DesktopWindowTreeHostMus's activation handling

Fixes bug in DesktopWindowTreeHostMus's activation handling

If Activate() is called before the window is visible, then the call
should fail. The way the code is now it assumed it would succeed so
that when Activate() was called again later on we wouldn't do the
right thing (because the activation client was already installed).

BUG=690709
TEST=covered by test
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2690553004
Cr-Commit-Position: refs/heads/master@{#449721}
Committed: https://chromium.googlesource.com/chromium/src/+/b52e3c3e96944729c7f6a02b42f5c1b6d01dee24

[sky, 2017-02-10 19:18:48]

https://codereview.chromium.org/2690553004/diff/1/ui/views/mus/desktop_window...
File ui/views/mus/desktop_window_tree_host_mus.cc (left):

https://codereview.chromium.org/2690553004/diff/1/ui/views/mus/desktop_window...
ui/views/mus/desktop_window_tree_host_mus.cc:537: window()->Focus();
The explicit call to Focus() isn't necessary here as HandleActivationChanged()
(called in OnActiveFocusClientChanged()) focuses the right window.

[sky, 2017-02-10 19:18:52]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 19:19:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-02-10 19:39:14]

sadrul@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2017-02-10 19:39:14]

cool! lgtm

[Elliot Glaysher, 2017-02-10 19:58:57]

lgtm

[sky, 2017-02-10 20:29:55]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-02-10 20:29:58]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-02-10 20:30:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 20:34:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486758598423380, "parent_rev":
"d4d3f8c40a45bba141630485d0c06d4367fc7c95", "commit_rev":
"b52e3c3e96944729c7f6a02b42f5c1b6d01dee24"}

[commit-bot: I haz the power, 2017-02-10 20:35:18]

Description was changed from

==========
Fixes bug in DesktopWindowTreeHostMus's activation handling

If Activate() is called before the window is visible, then the call
should fail. The way the code is now it assumed it would succeed so
that when Activate() was called again later on we wouldn't do the
right thing (because the activation client was already installed).

BUG=690709
TEST=covered by test
R=erg@chromium.org
==========

to

==========
Fixes bug in DesktopWindowTreeHostMus's activation handling

If Activate() is called before the window is visible, then the call
should fail. The way the code is now it assumed it would succeed so
that when Activate() was called again later on we wouldn't do the
right thing (because the activation client was already installed).

BUG=690709
TEST=covered by test
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2690553004
Cr-Commit-Position: refs/heads/master@{#449721}
Committed:
https://chromium.googlesource.com/chromium/src/+/b52e3c3e96944729c7f6a02b42f5...
==========

[commit-bot: I haz the power, 2017-02-10 20:35:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b52e3c3e96944729c7f6a02b42f5...