Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2690473002:
Android/a11y: Add string for a11y "feed" role. (Closed)
|
Created:
3 years, 10 months ago by Patti Lor Modified:
3 years, 10 months ago CC:
aboxhall+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, mac-reviews_chromium.org, nektar+watch_chromium.org, tfarina, yuzo+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAndroid/a11y: Add string for a11y "feed" role.
Add a string for ui::AX_ROLE_FEED's role description used in Android a11y.
Review-Url: https://codereview.chromium.org/2690473002
Cr-Commit-Position: refs/heads/master@{#451255}
Committed: https://chromium.googlesource.com/chromium/src/+/6b744382ee8ebb3df7d2c4487aa3e7a11d47f299
Patch Set 1 #Patch Set 2 : Rebase on dependent CL properly. #Patch Set 3 : Dependency landed, rebase. #
Total comments: 2
Patch Set 4 : Fix string to actually say the right thing. #Patch Set 5 : Remove spelling fixes #
Dependent Patchsets: Messages
Total messages: 48 (34 generated)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Patchset #3 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
patricialor@chromium.org changed reviewers: + dmazzoni@chromium.org, jochen@chromium.org
Hi all, please review changes as follows: jochen@: content/app/strings/content_strings.grd dmazzoni@: content/browser/accessibility/browser_accessibility_android.cc Thanks!
lgtm with one accidental error. Thanks for adding this! https://codereview.chromium.org/2690473002/diff/60001/content/app/strings/con... File content/app/strings/content_strings.grd (right): https://codereview.chromium.org/2690473002/diff/60001/content/app/strings/con... content/app/strings/content_strings.grd:298: figure This should be "feed"
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
https://codereview.chromium.org/2690473002/diff/60001/content/app/strings/con... File content/app/strings/content_strings.grd (right): https://codereview.chromium.org/2690473002/diff/60001/content/app/strings/con... content/app/strings/content_strings.grd:298: figure On 2017/02/13 19:42:21, dmazzoni wrote: > This should be "feed" Whoops, thanks heaps for picking this up :)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
would it be possible to move the spelling changes to a separate CL?
The CQ bit was checked by patricialor@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Done, see https://codereview.chromium.org/2694283005/ (have also sent this to you directly as well).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by patricialor@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2690473002/#ps100001 (title: "Remove spelling fixes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by patricialor@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by patricialor@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by patricialor@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487311356113430,
"parent_rev": "8a7821b7fc3a4d1394306e296be8274818ac1057", "commit_rev":
"6b744382ee8ebb3df7d2c4487aa3e7a11d47f299"}
Message was sent while issue was closed.
Description was changed from ========== Android/a11y: Add string for a11y "feed" role. Add a string for ui::AX_ROLE_FEED's role description used in Android a11y. ========== to ========== Android/a11y: Add string for a11y "feed" role. Add a string for ui::AX_ROLE_FEED's role description used in Android a11y. Review-Url: https://codereview.chromium.org/2690473002 Cr-Commit-Position: refs/heads/master@{#451255} Committed: https://chromium.googlesource.com/chromium/src/+/6b744382ee8ebb3df7d2c4487aa3... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as https://chromium.googlesource.com/chromium/src/+/6b744382ee8ebb3df7d2c4487aa3... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
