Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2690463003: SpeechRecognizerImplTest flakiness fix. (Closed)

Created:
3 years, 10 months ago by o1ka
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SpeechRecognizerImplTest flakiness fix. SpeechRecognizerImpl::StartRecognition() is asynchronous, so we must run loop after calling it to make sure it has executed and has posted device info request to the audio thread before we begin to wait for the audio thread reply. BUG=690555, 687981 Review-Url: https://codereview.chromium.org/2690463003 Cr-Commit-Position: refs/heads/master@{#449591} Committed: https://chromium.googlesource.com/chromium/src/+/0bf2c9cdf5dc8bbf2acaac5a5ae4df03c5eaefeb

Patch Set 1 #

Patch Set 2 : procession -> processing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M content/browser/speech/speech_recognizer_impl_unittest.cc View 1 12 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
o1ka
Tommi PTAL (bots are running for PS1, I don't want to bother them for a ...
3 years, 10 months ago (2017-02-10 10:48:17 UTC) #4
tommi (sloooow) - chröme
lgtm
3 years, 10 months ago (2017-02-10 10:49:04 UTC) #5
o1ka
On 2017/02/10 10:49:04, tommi (krómíum) wrote: > lgtm thanks!
3 years, 10 months ago (2017-02-10 11:25:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690463003/20001
3 years, 10 months ago (2017-02-10 11:25:22 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 11:57:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0bf2c9cdf5dc8bbf2acaac5a5ae4...

Powered by Google App Engine
This is Rietveld 408576698