mash: Fix shutdown hang in content_browser

mash: Fix shutdown hang in content_browser

This was causing the root process to hang when ash crashes and we try to
shut down all the other services.

Two code paths to remove connection filters on the IO thread were racing,
resulting in an attempt to erase an invalid iterator from a map.

BUG=687247
TEST=chrome --mash and kill ash process results in clean browser shutdown

Review-Url: https://codereview.chromium.org/2690453002
Cr-Commit-Position: refs/heads/master@{#449455}
Committed: https://chromium.googlesource.com/chromium/src/+/c00c082eeae3c7281f73343bc39c0b6285128450

[James Cook, 2017-02-09 22:12:53]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 22:13:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-02-09 22:13:33]

jamescook@chromium.org changed reviewers:
+ rockot@chromium.org

[James Cook, 2017-02-09 22:13:34]

Ken, please take a look.

[Ken Rockot(use gerrit already), 2017-02-09 22:46:32]

lgtm

[James Cook, 2017-02-09 22:48:38]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2017-02-09 22:48:44]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-02-09 22:49:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 23:16:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486680524430980, "parent_rev":
"f8458d55b3619c6820b9095adf63d8fa2aa7e17b", "commit_rev":
"c00c082eeae3c7281f73343bc39c0b6285128450"}

[commit-bot: I haz the power, 2017-02-09 23:17:13]

Description was changed from

==========
mash: Fix shutdown hang in content_browser

This was causing the root process to hang when ash crashes and we try to
shut down all the other services.

Two code paths to remove connection filters on the IO thread were racing,
resulting in an attempt to erase an invalid iterator from a map.

BUG=687247
TEST=chrome --mash and kill ash process results in clean browser shutdown
==========

to

==========
mash: Fix shutdown hang in content_browser

This was causing the root process to hang when ash crashes and we try to
shut down all the other services.

Two code paths to remove connection filters on the IO thread were racing,
resulting in an attempt to erase an invalid iterator from a map.

BUG=687247
TEST=chrome --mash and kill ash process results in clean browser shutdown

Review-Url: https://codereview.chromium.org/2690453002
Cr-Commit-Position: refs/heads/master@{#449455}
Committed:
https://chromium.googlesource.com/chromium/src/+/c00c082eeae3c7281f73343bc39c...
==========

[commit-bot: I haz the power, 2017-02-09 23:17:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c00c082eeae3c7281f73343bc39c...