Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2690343005: Convert MediaStreamAudioSource test to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 9 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert MediaStreamAudioSource test to testharness Manually convert the test to use testharness and new Audit. BUG=692724 TEST=mediastreamaudiosourcenode.html Review-Url: https://codereview.chromium.org/2690343005 Cr-Commit-Position: refs/heads/master@{#455182} Committed: https://chromium.googlesource.com/chromium/src/+/8f98597ba6a3add1e39d0f824fc8e96ee4f663b7

Patch Set 1 #

Patch Set 2 : Remove task.describe #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -97 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html View 1 1 chunk +62 lines, -80 lines 3 comments Download
D third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-24 17:34:23 UTC) #2
hongchan
https://codereview.chromium.org/2690343005/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html File third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html (right): https://codereview.chromium.org/2690343005/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html#newcode34 third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html:34: .notThrow(); If clang-format did this, it is really bad. ...
3 years, 10 months ago (2017-02-24 23:28:09 UTC) #3
Raymond Toy
https://codereview.chromium.org/2690343005/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html File third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html (right): https://codereview.chromium.org/2690343005/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html#newcode34 third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html:34: .notThrow(); On 2017/02/24 23:28:09, hongchan wrote: > If clang-format ...
3 years, 10 months ago (2017-02-24 23:35:30 UTC) #4
hongchan
https://codereview.chromium.org/2690343005/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html File third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html (right): https://codereview.chromium.org/2690343005/diff/20001/third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html#newcode34 third_party/WebKit/LayoutTests/webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html:34: .notThrow(); On 2017/02/24 23:35:30, Raymond Toy wrote: > On ...
3 years, 10 months ago (2017-02-24 23:48:18 UTC) #5
hongchan
lgtm I will leave this to you. However, handling of getUserMedia callback really could use ...
3 years, 9 months ago (2017-03-07 17:58:01 UTC) #6
Raymond Toy
On 2017/03/07 17:58:01, hongchan wrote: > lgtm > > I will leave this to you. ...
3 years, 9 months ago (2017-03-07 18:08:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690343005/20001
3 years, 9 months ago (2017-03-07 18:10:49 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 19:54:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8f98597ba6a3add1e39d0f824fc8...

Powered by Google App Engine
This is Rietveld 408576698