Hide kernel isolate from isolate list; do not register it either

runtime/lib/vmservice.cc

Index: runtime/lib/vmservice.cc
diff --git a/runtime/lib/vmservice.cc b/runtime/lib/vmservice.cc
index 9d83c13b9d8e421a7bb7b734f77843d561c7e655..e1df5a1db71949f95d004e25a8ca8833702c4f58 100644
--- a/runtime/lib/vmservice.cc
+++ b/runtime/lib/vmservice.cc
@@ -16,6 +16,7 @@
 #include "vm/service_event.h"
 #include "vm/service_isolate.h"
 #include "vm/symbols.h"
+#include "vm/kernel_isolate.h"
 
 namespace dart {
 
@@ -57,8 +58,13 @@ class RegisterRunningIsolatesVisitor : public IsolateVisitor {
 
   virtual void VisitIsolate(Isolate* isolate) {
     ASSERT(ServiceIsolate::IsServiceIsolate(Isolate::Current()));
-    if (IsVMInternalIsolate(isolate)) {
-      // We do not register the service (and descendants) or the vm-isolate.
+    bool is_kernel_isolate = false;
+#ifndef DART_PRECOMPILED_RUNTIME
+    is_kernel_isolate = KernelIsolate::IsKernelIsolate(isolate);
+#endif
+    if (IsVMInternalIsolate(isolate) || is_kernel_isolate) {

[Vyacheslav Egorov (Google), 2017/02/14 13:02:25]

Maybe this should just move this check into the IsVMInternalIsolate?

+      // We do not register the service (and descendants), the vm-isolate, or
+      // the kernel isolate.
       return;
     }
     // Setup arguments for call.