Hide kernel isolate from isolate list; do not register it either

runtime/lib/vmservice.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 #include "vm/dart_api_impl.h"
 #include "vm/datastream.h"
 #include "vm/exceptions.h"
 #include "vm/flags.h"
 #include "vm/growable_array.h"
 #include "vm/message.h"
 #include "vm/message_handler.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/port.h"
 #include "vm/service_event.h"
 #include "vm/service_isolate.h"
 #include "vm/symbols.h"
+#include "vm/kernel_isolate.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, trace_service);
 
 static uint8_t* malloc_allocator(uint8_t* ptr,
                                  intptr_t old_size,
                                  intptr_t new_size) {
   void* new_ptr = realloc(reinterpret_cast<void*>(ptr), new_size);
   return reinterpret_cast<uint8_t*>(new_ptr);
@@ skipping 21 matching lines @@
     // Get function.
     const String& function_name =
         String::Handle(String::New("_registerIsolate"));
     ASSERT(!function_name.IsNull());
     register_function_ = library.LookupFunctionAllowPrivate(function_name);
     ASSERT(!register_function_.IsNull());
   }
 
   virtual void VisitIsolate(Isolate* isolate) {
     ASSERT(ServiceIsolate::IsServiceIsolate(Isolate::Current()));
-    if (IsVMInternalIsolate(isolate)) {
-      // We do not register the service (and descendants) or the vm-isolate.
+    bool is_kernel_isolate = false;
+#ifndef DART_PRECOMPILED_RUNTIME
+    is_kernel_isolate = KernelIsolate::IsKernelIsolate(isolate);
+#endif
+    if (IsVMInternalIsolate(isolate) || is_kernel_isolate) {

[Vyacheslav Egorov (Google), 2017/02/14 13:02:25]

Maybe this should just move this check into the IsVMInternalIsolate?

+      // We do not register the service (and descendants), the vm-isolate, or
+      // the kernel isolate.
       return;
     }
     // Setup arguments for call.
     Dart_Port port_id = isolate->main_port();
     const Integer& port_int = Integer::Handle(Integer::New(port_id));
     ASSERT(!port_int.IsNull());
     const SendPort& send_port = SendPort::Handle(SendPort::New(port_id));
     const String& name = String::Handle(String::New(isolate->name()));
     ASSERT(!name.IsNull());
     const Array& args = Array::Handle(Array::New(3));
@@ skipping 399 matching lines @@
     ServiceEvent spawn_event(NULL, ServiceEvent::kIsolateSpawn);
     spawn_event.set_spawn_token(&token);
     spawn_event.set_spawn_error(&String::Cast(result));
     Service::HandleEvent(&spawn_event);
   }
 #endif  // PRODUCT
   return Object::null();
 }
 
 }  // namespace dart